Re: [PATCH v2 0/3] fix GCC optimizations and warnings for SetJump/LongJump

["Gao, Liming" <liming.gao@intel.com>]

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: M1cha [mailto:sigmaepsilon92@gmail.com]
> Sent: Saturday, December 23, 2017 3:17 AM
> To: edk2-devel@lists.01.org
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <liming.gao@intel.com>
> Subject: [edk2] [PATCH v2 0/3] fix GCC optimizations and warnings for SetJump/LongJump
> 
> I've already discussed this in past but never actually sent proper
> patches for some reason.
> 
> This patch series is about fixing problems with these functions when
> using GCC.
> 
> V2:
> * add attributes to C-files too
> * remove useless condition in RETURNS_TWICE macro
> 
> M1cha (3):
>   MdePkg: add RETURNS_TWICE attribute
>   MdePkg/BaseLib: add attribute 'RETURNS_TWICE' to SetJump
>   MdePkg: add NORETURN attribute to LongJump and InternalLongJump
> 
>  MdePkg/Include/Base.h                        | 8 ++++++++
>  MdePkg/Include/Library/BaseLib.h             | 2 ++
>  MdePkg/Library/BaseLib/BaseLibInternals.h    | 1 +
>  MdePkg/Library/BaseLib/Ebc/SetJumpLongJump.c | 2 ++
>  MdePkg/Library/BaseLib/Ia32/LongJump.c       | 1 +
>  MdePkg/Library/BaseLib/Ia32/SetJump.c        | 1 +
>  MdePkg/Library/BaseLib/LongJump.c            | 1 +
>  7 files changed, 16 insertions(+)
> 
> --
> 2.15.1