From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D448822280C21 for ; Fri, 29 Dec 2017 07:16:06 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Dec 2017 07:21:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,475,1508828400"; d="scan'208";a="16437785" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga004.fm.intel.com with ESMTP; 29 Dec 2017 07:21:04 -0800 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 29 Dec 2017 07:21:03 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 29 Dec 2017 07:21:03 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.152]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.218]) with mapi id 14.03.0319.002; Fri, 29 Dec 2017 23:21:01 +0800 From: "Gao, Liming" To: M1cha , "edk2-devel@lists.01.org" CC: Ard Biesheuvel , "Kinney, Michael D" Thread-Topic: [edk2] [PATCH v2 0/3] fix GCC optimizations and warnings for SetJump/LongJump Thread-Index: AQHTe1lyTJrajsMLq0ea3dYJOSc726NaeoxA Date: Fri, 29 Dec 2017 15:21:01 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E19B34D@SHSMSX104.ccr.corp.intel.com> References: <20171222191640.5313-1-sigmaepsilon92@gmail.com> In-Reply-To: <20171222191640.5313-1-sigmaepsilon92@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 0/3] fix GCC optimizations and warnings for SetJump/LongJump X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Dec 2017 15:16:07 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: M1cha [mailto:sigmaepsilon92@gmail.com] > Sent: Saturday, December 23, 2017 3:17 AM > To: edk2-devel@lists.01.org > Cc: Ard Biesheuvel ; Kinney, Michael D ; Gao, Liming > > Subject: [edk2] [PATCH v2 0/3] fix GCC optimizations and warnings for Set= Jump/LongJump >=20 > I've already discussed this in past but never actually sent proper > patches for some reason. >=20 > This patch series is about fixing problems with these functions when > using GCC. >=20 > V2: > * add attributes to C-files too > * remove useless condition in RETURNS_TWICE macro >=20 > M1cha (3): > MdePkg: add RETURNS_TWICE attribute > MdePkg/BaseLib: add attribute 'RETURNS_TWICE' to SetJump > MdePkg: add NORETURN attribute to LongJump and InternalLongJump >=20 > MdePkg/Include/Base.h | 8 ++++++++ > MdePkg/Include/Library/BaseLib.h | 2 ++ > MdePkg/Library/BaseLib/BaseLibInternals.h | 1 + > MdePkg/Library/BaseLib/Ebc/SetJumpLongJump.c | 2 ++ > MdePkg/Library/BaseLib/Ia32/LongJump.c | 1 + > MdePkg/Library/BaseLib/Ia32/SetJump.c | 1 + > MdePkg/Library/BaseLib/LongJump.c | 1 + > 7 files changed, 16 insertions(+) >=20 > -- > 2.15.1