From: "Gao, Liming" <liming.gao@intel.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTools: Fix compile error on VS2010
Date: Wed, 3 Jan 2018 05:58:48 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E19DABD@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1514958506-6872-1-git-send-email-yonghong.zhu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Yonghong Zhu
>Sent: Wednesday, January 03, 2018 1:48 PM
>To: edk2-devel@lists.01.org
>Subject: [edk2] [Patch] BaseTools: Fix compile error on VS2010
>
>VS2010 also defined RSIZE_MAX, so we undef it first.
>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
>---
> BaseTools/Source/C/Common/CommonLib.h | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/BaseTools/Source/C/Common/CommonLib.h
>b/BaseTools/Source/C/Common/CommonLib.h
>index 9da16e8..dccb192 100644
>--- a/BaseTools/Source/C/Common/CommonLib.h
>+++ b/BaseTools/Source/C/Common/CommonLib.h
>@@ -1,9 +1,9 @@
> /** @file
> Common library assistance routines.
>
>-Copyright (c) 2004 - 2017, Intel Corporation. All rights reserved.<BR>
>+Copyright (c) 2004 - 2018, Intel Corporation. All rights reserved.<BR>
> This program and the accompanying materials
> are licensed and made available under the terms and conditions of the BSD
>License
> which accompanies this distribution. The full text of the license may be found
>at
> http://opensource.org/licenses/bsd-license.php
>
>@@ -26,13 +26,12 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY
>KIND, EITHER EXPRESS OR IMPLIED.
> #define MAX_UINT64 ((UINT64)0xFFFFFFFFFFFFFFFFULL)
> #define MAX_UINT16 ((UINT16)0xFFFF)
> #define MAX_UINT8 ((UINT8)0xFF)
> #define ARRAY_SIZE(Array) (sizeof (Array) / sizeof ((Array)[0]))
> #define ASCII_RSIZE_MAX 1000000
>-#ifndef RSIZE_MAX
>+#undef RSIZE_MAX
> #define RSIZE_MAX 1000000
>-#endif
>
> #define IS_COMMA(a) ((a) == L',')
> #define IS_HYPHEN(a) ((a) == L'-')
> #define IS_DOT(a) ((a) == L'.')
> #define IS_LEFT_PARENTH(a) ((a) == L'(')
>--
>2.6.1.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2018-01-03 5:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-03 5:48 [Patch] BaseTools: Fix compile error on VS2010 Yonghong Zhu
2018-01-03 5:58 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E19DABD@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox