From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E8159222275A3 for ; Sun, 7 Jan 2018 19:28:49 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jan 2018 19:33:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,329,1511856000"; d="scan'208";a="19746793" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga001.fm.intel.com with ESMTP; 07 Jan 2018 19:33:58 -0800 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 7 Jan 2018 19:33:58 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 7 Jan 2018 19:33:58 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.152]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002; Mon, 8 Jan 2018 11:33:56 +0800 From: "Gao, Liming" To: "Feng, Bob C" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch] BaseTools: Fix an issue in HiiPcd generation Thread-Index: AQHTg2TbzWhb15XVTkmr0AWI9+xQnqNpXDjA Date: Mon, 8 Jan 2018 03:33:55 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1A0184@SHSMSX104.ccr.corp.intel.com> References: <20180102005833.4452-1-bob.c.feng@intel.com> In-Reply-To: <20180102005833.4452-1-bob.c.feng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools: Fix an issue in HiiPcd generation X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jan 2018 03:28:50 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >BobCF >Sent: Tuesday, January 02, 2018 8:59 AM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [edk2] [Patch] BaseTools: Fix an issue in HiiPcd generation > >DynamicHiiPcd may be used by PEIM or DXE driver. >All used DynamicHiiPcd value should be collected and placed into >the default setting PCD PcdNvStoreDefaultValueBuffer. > >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Bob Feng >Cc: Liming Gao >--- > BaseTools/Source/Python/AutoGen/AutoGen.py | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > >diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py >b/BaseTools/Source/Python/AutoGen/AutoGen.py >index 8be5bfca83..758355c366 100644 >--- a/BaseTools/Source/Python/AutoGen/AutoGen.py >+++ b/BaseTools/Source/Python/AutoGen/AutoGen.py >@@ -1403,13 +1403,12 @@ class PlatformAutoGen(AutoGen): > if SkuId =3D=3D None or SkuId =3D=3D '': > continue > if len(Sku.VariableName) > 0: > VariableGuidStructure =3D Sku.VariableGuidValue > VariableGuid =3D >GuidStructureStringToGuidString(VariableGuidStructure) >- if Pcd.Phase =3D=3D "DXE": >- for StorageName in Sku.DefaultStoreDict: >- >VariableInfo.append_variable(var_info(Index,pcdname,StorageName,SkuNa >me, StringToArray(Sku.VariableName),VariableGuid, Sku.VariableAttribute , >Sku.HiiDefaultValue,Sku.DefaultStoreDict[StorageName],Pcd.DatumType)) >+ for StorageName in Sku.DefaultStoreDict: >+ >VariableInfo.append_variable(var_info(Index,pcdname,StorageName,SkuNa >me, StringToArray(Sku.VariableName),VariableGuid, Sku.VariableAttribute , >Sku.HiiDefaultValue,Sku.DefaultStoreDict[StorageName],Pcd.DatumType)) > Index +=3D 1 > return VariableInfo > > def UpdateNVStoreMaxSize(self,OrgVpdFile): > if self.VariableInfo: >-- >2.14.3.windows.1 > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel