Re: [PATCH] CryptoPkg/OpensslLib: Suppress format warning with extra flag.

["Gao, Liming" <liming.gao@intel.com>]

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Long, Qin
> Sent: Friday, January 12, 2018 11:20 AM
> To: edk2-devel@lists.01.org
> Cc: ard.biesheuvel@linaro.org; Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH] CryptoPkg/OpensslLib: Suppress format warning with extra flag.
> 
> Under a certain [outdated] GCC482 compiler, the new-added "-Wno-format"
> flag will not take effect, and break the x86_64 build.
> This is one known issue in some Ubuntu/GCC-4.8.2 environment, which will
> overwrite "-Wno-format" with some default setting.  see more information
> and discussion from:
>   https://gcc.gnu.org/ml/gcc-help/2014-03/msg00003.html
>   https://wiki.ubuntu.com/ToolChain/CompilerFlags
> This patch adds one extra "-Wno-error=format" for gcc x86_64 builds to
> suppress this warning.
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Long Qin <qin.long@intel.com>
> ---
>  CryptoPkg/Library/OpensslLib/OpensslLib.inf       | 2 +-
>  CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> index f3eb19afd3..10021f8503 100644
> --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> @@ -557,7 +557,7 @@
>    #                   types appropriate to the format string specified.
>    #
>    GCC:*_*_IA32_CC_FLAGS    = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized
> -  GCC:*_*_X64_CC_FLAGS     = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-format
> -DNO_MSABI_VA_FUNCS
> +  GCC:*_*_X64_CC_FLAGS     = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-error=format
> -Wno-format -DNO_MSABI_VA_FUNCS
>    GCC:*_*_IPF_CC_FLAGS     = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-format
>    GCC:*_*_ARM_CC_FLAGS     = $(OPENSSL_FLAGS)
>    GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-format
> diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
> index 88134b5b5f..ff598e7d43 100644
> --- a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
> +++ b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
> @@ -518,7 +518,7 @@
>    #                   types appropriate to the format string specified.
>    #
>    GCC:*_*_IA32_CC_FLAGS    = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized
> -  GCC:*_*_X64_CC_FLAGS     = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-format
> -DNO_MSABI_VA_FUNCS
> +  GCC:*_*_X64_CC_FLAGS     = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-error=format
> -Wno-format -DNO_MSABI_VA_FUNCS
>    GCC:*_*_IPF_CC_FLAGS     = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-format
>    GCC:*_*_ARM_CC_FLAGS     = $(OPENSSL_FLAGS)
>    GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-format
> --
> 2.15.1.windows.2