From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AA61B2205B90B for ; Thu, 11 Jan 2018 19:33:05 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jan 2018 19:38:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,347,1511856000"; d="scan'208";a="9007685" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga007.fm.intel.com with ESMTP; 11 Jan 2018 19:38:19 -0800 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 11 Jan 2018 19:38:19 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 11 Jan 2018 19:38:18 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.152]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Fri, 12 Jan 2018 11:38:17 +0800 From: "Gao, Liming" To: "Long, Qin" , "edk2-devel@lists.01.org" CC: "ard.biesheuvel@linaro.org" Thread-Topic: [PATCH] CryptoPkg/OpensslLib: Suppress format warning with extra flag. Thread-Index: AQHTi1RMIN9BM1SqT0q86p7Kvy4t2qNvluIg Date: Fri, 12 Jan 2018 03:38:16 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1A3CFB@SHSMSX104.ccr.corp.intel.com> References: <20180112031943.11016-1-qin.long@intel.com> In-Reply-To: <20180112031943.11016-1-qin.long@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] CryptoPkg/OpensslLib: Suppress format warning with extra flag. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jan 2018 03:33:06 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Long, Qin > Sent: Friday, January 12, 2018 11:20 AM > To: edk2-devel@lists.01.org > Cc: ard.biesheuvel@linaro.org; Gao, Liming > Subject: [PATCH] CryptoPkg/OpensslLib: Suppress format warning with extra= flag. >=20 > Under a certain [outdated] GCC482 compiler, the new-added "-Wno-format" > flag will not take effect, and break the x86_64 build. > This is one known issue in some Ubuntu/GCC-4.8.2 environment, which will > overwrite "-Wno-format" with some default setting. see more information > and discussion from: > https://gcc.gnu.org/ml/gcc-help/2014-03/msg00003.html > https://wiki.ubuntu.com/ToolChain/CompilerFlags > This patch adds one extra "-Wno-error=3Dformat" for gcc x86_64 builds to > suppress this warning. >=20 > Cc: Ard Biesheuvel > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Long Qin > --- > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 2 +- > CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf b/CryptoPkg/Libr= ary/OpensslLib/OpensslLib.inf > index f3eb19afd3..10021f8503 100644 > --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf > +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf > @@ -557,7 +557,7 @@ > # types appropriate to the format string specified. > # > GCC:*_*_IA32_CC_FLAGS =3D -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -Wno-e= rror=3Dmaybe-uninitialized > - GCC:*_*_X64_CC_FLAGS =3D -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -Wno-e= rror=3Dmaybe-uninitialized -Wno-format > -DNO_MSABI_VA_FUNCS > + GCC:*_*_X64_CC_FLAGS =3D -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -Wno-e= rror=3Dmaybe-uninitialized -Wno-error=3Dformat > -Wno-format -DNO_MSABI_VA_FUNCS > GCC:*_*_IPF_CC_FLAGS =3D -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -Wno-e= rror=3Dmaybe-uninitialized -Wno-format > GCC:*_*_ARM_CC_FLAGS =3D $(OPENSSL_FLAGS) > GCC:*_*_AARCH64_CC_FLAGS =3D $(OPENSSL_FLAGS) -Wno-format > diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf b/CryptoPk= g/Library/OpensslLib/OpensslLibCrypto.inf > index 88134b5b5f..ff598e7d43 100644 > --- a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > +++ b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > @@ -518,7 +518,7 @@ > # types appropriate to the format string specified. > # > GCC:*_*_IA32_CC_FLAGS =3D -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -Wno-e= rror=3Dmaybe-uninitialized > - GCC:*_*_X64_CC_FLAGS =3D -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -Wno-e= rror=3Dmaybe-uninitialized -Wno-format > -DNO_MSABI_VA_FUNCS > + GCC:*_*_X64_CC_FLAGS =3D -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -Wno-e= rror=3Dmaybe-uninitialized -Wno-error=3Dformat > -Wno-format -DNO_MSABI_VA_FUNCS > GCC:*_*_IPF_CC_FLAGS =3D -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -Wno-e= rror=3Dmaybe-uninitialized -Wno-format > GCC:*_*_ARM_CC_FLAGS =3D $(OPENSSL_FLAGS) > GCC:*_*_AARCH64_CC_FLAGS =3D $(OPENSSL_FLAGS) -Wno-format > -- > 2.15.1.windows.2