From: "Gao, Liming" <liming.gao@intel.com>
To: Laszlo Ersek <lersek@redhat.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] Edk2: Retire Edk2Setup.bat
Date: Wed, 17 Jan 2018 01:53:26 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1A54D8@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <d4537e3b-e2e6-45c3-066f-95993576ec9e@redhat.com>
Laszlo:
BaseTools owner should fix and review those batch files. And, thanks for your review.
Hi, all
I don't get the different opinion so far. I will wait for one more week. If no comments, I will do this change.
Thanks
Liming
>-----Original Message-----
>From: Laszlo Ersek [mailto:lersek@redhat.com]
>Sent: Thursday, January 11, 2018 6:30 PM
>To: Gao, Liming <liming.gao@intel.com>
>Cc: edk2-devel@lists.01.org
>Subject: Re: [edk2] [Patch] Edk2: Retire Edk2Setup.bat
>
>On 01/11/18 09:21, Liming Gao wrote:
>> Edk2Setup.bat is out of maintain. It is a draft version batch file, and not
>> implement all features listed in its header file. To avoid the confuse,
>> drop it from edk2 project, and keep edksetup.bat only.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Liming Gao <liming.gao@intel.com>
>> ---
>> Edk2Setup.bat | 541 ----------------------------------------------------------
>> 1 file changed, 541 deletions(-)
>> delete mode 100755 Edk2Setup.bat
>
>Meta-question: who is supposed to review such (top-level) patches?
>
>FWIW, I'm fine with the proposal.
>
>Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>
>Thanks
>Laszlo
prev parent reply other threads:[~2018-01-17 1:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 8:21 [Patch] Edk2: Retire Edk2Setup.bat Liming Gao
2018-01-11 10:29 ` Laszlo Ersek
2018-01-17 1:53 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E1A54D8@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox