Re: [PATCH v1 1/1] MdePkg/Include: Add management mode FV file type and depex.

["Gao, Liming" <liming.gao@intel.com>]

Supreeth:
  I suggest to add all MM type and section definition in MdePkg. They are not many. After they are added, SMM definition can be defined to MM value. 

Thanks
Liming
> -----Original Message-----
> From: Supreeth Venkatesh [mailto:Supreeth.Venkatesh@arm.com]
> Sent: Friday, January 26, 2018 5:21 AM
> To: Marvin H?user <Marvin.Haeuser@outlook.com>; edk2-devel@lists.01.org; tim.lewis@insyde.com
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: RE: [edk2] [PATCH v1 1/1] MdePkg/Include: Add management mode FV file type and depex.
> 
> Marvin/Tim,
> 
> Thanks.
> Apologies, if I didn't mention that this patch was just addition of new values
> EFI_FV_FILETYPE_MM_STANDALONE
> EFI_FV_FILETYPE_MM_CORE_STANDALONE
> and
> EFI_SECTION_MM_DEPEX
> 
> No other changes.
> In existing code, EFI_FV_FILETYPE_SMM  and EFI_FV_FILETYPE_MM are same already.
> 
> Supreeth
> -----Original Message-----
> From: Marvin H?user [mailto:Marvin.Haeuser@outlook.com]
> Sent: Thursday, January 25, 2018 12:32 PM
> To: edk2-devel@lists.01.org; tim.lewis@insyde.com; Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>
> Cc: michael.d.kinney@intel.com; liming.gao@intel.com
> Subject: RE: [edk2] [PATCH v1 1/1] MdePkg/Include: Add management mode FV file type and depex.
> 
> Hey Tim and Supreeth,
> 
> Sorry, 0x0C was a typo, 0x0D is the correct one.
> The values of the SMM and MM constants are identical, this is just a naming update plus the introduction of the new value, MM
> Standalone Core, so backwards-compatibility is given.
> Regarding the traditional MM Core, I just assumed it was an oversight as MdePkg is generic. If it wasn't, sorry.
> 
> Thanks,
> Marvin
> 
> > -----Original Message-----
> > From: Tim Lewis [mailto:tim.lewis@insyde.com]
> > Sent: Thursday, January 25, 2018 6:53 PM
> > To: 'Supreeth Venkatesh' <Supreeth.Venkatesh@arm.com>; 'Marvin H?user'
> > <Marvin.Haeuser@outlook.com>; edk2-devel@lists.01.org
> > Cc: michael.d.kinney@intel.com; liming.gao@intel.com
> > Subject: RE: [edk2] [PATCH v1 1/1] MdePkg/Include: Add management mode
> > FV file type and depex.
> >
> > Supreeth --
> >
> > Doesn't Appendix A of the PI 1.6 define this as:
> >
> > #define EFI_FV_FILETYPE_SMM EFI_FV_FILETYPE_MM #define
> > EFI_FV_FILETYPE_SMM_CORE EFI_FV_FILETYPE_MM_CORE
> >
> > Thanks,
> >
> > Tim
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > Supreeth Venkatesh
> > Sent: Thursday, January 25, 2018 9:45 AM
> > To: Marvin H?user <Marvin.Haeuser@outlook.com>; edk2-
> > devel@lists.01.org
> > Cc: michael.d.kinney@intel.com; liming.gao@intel.com
> > Subject: Re: [edk2] [PATCH v1 1/1] MdePkg/Include: Add management mode
> > FV file type and depex.
> >
> > Marvin,
> >
> > Thanks for your comments.
> > As per PI v1.6 specification,
> > EFI_FV_FILETYPE_MM_CORE value is 0x0D (MM Foundation that support MM
> > Traditional Mode.)
> >
> > This is traditional MM mode, which ARM is not supporting at this
> > point. We are more interested in MM_CORE_STANDALONE mode.
> > However, I have no issues in adding this in the patch, but would
> > prefer if this is added when MM traditional mode is supported in ARM.
> >
> > Further,
> > w.r.t defining *_SMM_* definitions via the *_MM_* definitions. I don't
> > want to break backwards compatibility with existing SMM traditional
> > mode implementations.
> > I will be happy to let folks who have migrated to _MM_ definitions
> > from _SMM_ definitions to send the patch across.
> >
> > Thanks,
> > Supreeth
> >
> > -----Original Message-----
> > From: Marvin H?user [mailto:Marvin.Haeuser@outlook.com]
> > Sent: Tuesday, January 23, 2018 6:34 PM
> > To: edk2-devel@lists.01.org
> > Cc: Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>;
> > michael.d.kinney@intel.com; liming.gao@intel.com
> > Subject: RE: [edk2] [PATCH v1 1/1] MdePkg/Include: Add management mode
> > FV file type and depex.
> >
> > Good day,
> >
> > I noticed this patch lacks the definition of "EFI_FV_FILETYPE_MM_CORE"
> > (0x0C).
> > Furthermore, may I suggest changing the *_SMM_* definitions to be
> > defined via the *_MM_* definitions?
> >
> > Best regards,
> > Marvin.
> >
> > > -----Original Message-----
> > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf
> > > Of Supreeth Venkatesh
> > > Sent: Tuesday, January 23, 2018 9:03 PM
> > > To: edk2-devel@lists.01.org
> > > Cc: michael.d.kinney@intel.com; liming.gao@intel.com
> > > Subject: [edk2] [PATCH v1 1/1] MdePkg/Include: Add management mode
> > FV
> > > file type and depex.
> > >
> > > As per PI specification v1.6,
> > > The following new file types are added:
> > > EFI_FV_FILETYPE_MM_STANDALONE
> > > EFI_FV_FILETYPE_MM_CORE_STANDALONE
> > >
> > > The following new section type is added:
> > > EFI_SECTION_MM_DEPEX
> > >
> > > This patch adds the management mode FV file type and depex.
> > >
> > > Contributed-under: TianoCore Contribution Agreement 1.1
> > > Signed-off-by: Achin Gupta <achin.gupta@arm.com>
> > > Signed-off-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> > > Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> > > ---
> > >  MdePkg/Include/Pi/PiFirmwareFile.h | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > >
> > > diff --git a/MdePkg/Include/Pi/PiFirmwareFile.h
> > > b/MdePkg/Include/Pi/PiFirmwareFile.h
> > > index b982c9eda3..6086d1bb2f 100644
> > > --- a/MdePkg/Include/Pi/PiFirmwareFile.h
> > > +++ b/MdePkg/Include/Pi/PiFirmwareFile.h
> > > @@ -72,9 +72,12 @@ typedef UINT8 EFI_FFS_FILE_STATE;  #define
> > > EFI_FV_FILETYPE_COMBINED_PEIM_DRIVER  0x08
> > >  #define EFI_FV_FILETYPE_APPLICATION           0x09
> > >  #define EFI_FV_FILETYPE_SMM                   0x0A
> > > +#define EFI_FV_FILETYPE_MM                    0x0A
> > >  #define EFI_FV_FILETYPE_FIRMWARE_VOLUME_IMAGE 0x0B
> > >  #define EFI_FV_FILETYPE_COMBINED_SMM_DXE      0x0C
> > > +#define EFI_FV_FILETYPE_COMBINED_MM_DXE       0x0C
> > >  #define EFI_FV_FILETYPE_SMM_CORE              0x0D
> > > +#define EFI_FV_FILETYPE_MM_STANDALONE         0x0E
> > >  #define EFI_FV_FILETYPE_OEM_MIN               0xc0
> > >  #define EFI_FV_FILETYPE_OEM_MAX               0xdf
> > >  #define EFI_FV_FILETYPE_DEBUG_MIN             0xe0
> > > @@ -218,6 +221,7 @@ typedef UINT8 EFI_SECTION_TYPE;
> > >  #define EFI_SECTION_RAW                   0x19
> > >  #define EFI_SECTION_PEI_DEPEX             0x1B
> > >  #define EFI_SECTION_SMM_DEPEX             0x1C
> > > +#define EFI_SECTION_MM_DEPEX              0x1C
> > >
> > >  ///
> > >  /// Common section header.
> > > --
> > > 2.14.1
> > >
> > > _______________________________________________
> > > edk2-devel mailing list
> > > edk2-devel@lists.01.org
> > > https://lists.01.org/mailman/listinfo/edk2-devel
> > IMPORTANT NOTICE: The contents of this email and any attachments are
> > confidential and may also be privileged. If you are not the intended
> > recipient, please notify the sender immediately and do not disclose
> > the contents to any other person, use it for any purpose, or store or
> > copy the information in any medium. Thank you.
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
> 
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the
> intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose,
> or store or copy the information in any medium. Thank you.