From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 20BE42215BD92 for ; Mon, 29 Jan 2018 06:50:12 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2018 06:55:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,431,1511856000"; d="scan'208";a="199512895" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga005.fm.intel.com with ESMTP; 29 Jan 2018 06:55:45 -0800 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 29 Jan 2018 06:55:45 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 29 Jan 2018 06:55:45 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.127]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.145]) with mapi id 14.03.0319.002; Mon, 29 Jan 2018 22:55:43 +0800 From: "Gao, Liming" To: Supreeth Venkatesh , Marvin H?user , "edk2-devel@lists.01.org" , "tim.lewis@insyde.com" CC: "Kinney, Michael D" Thread-Topic: [edk2] [PATCH v1 1/1] MdePkg/Include: Add management mode FV file type and depex. Thread-Index: AQHTlIU4b1SBXkd5J0mA/xhuJ6L/kqOBpvwAgAKyUoCAAAI1gIAACs8AgAAvTICABmLEUA== Date: Mon, 29 Jan 2018 14:55:43 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1B8FA4@SHSMSX104.ccr.corp.intel.com> References: <20180123200303.5547-1-supreeth.venkatesh@arm.com> <001601d39605$580f31b0$082d9510$@insyde.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v1 1/1] MdePkg/Include: Add management mode FV file type and depex. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jan 2018 14:50:13 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Supreeth: I suggest to add all MM type and section definition in MdePkg. They are n= ot many. After they are added, SMM definition can be defined to MM value.=20 Thanks Liming > -----Original Message----- > From: Supreeth Venkatesh [mailto:Supreeth.Venkatesh@arm.com] > Sent: Friday, January 26, 2018 5:21 AM > To: Marvin H?user ; edk2-devel@lists.01.org; = tim.lewis@insyde.com > Cc: Kinney, Michael D ; Gao, Liming > Subject: RE: [edk2] [PATCH v1 1/1] MdePkg/Include: Add management mode FV= file type and depex. >=20 > Marvin/Tim, >=20 > Thanks. > Apologies, if I didn't mention that this patch was just addition of new v= alues > EFI_FV_FILETYPE_MM_STANDALONE > EFI_FV_FILETYPE_MM_CORE_STANDALONE > and > EFI_SECTION_MM_DEPEX >=20 > No other changes. > In existing code, EFI_FV_FILETYPE_SMM and EFI_FV_FILETYPE_MM are same al= ready. >=20 > Supreeth > -----Original Message----- > From: Marvin H?user [mailto:Marvin.Haeuser@outlook.com] > Sent: Thursday, January 25, 2018 12:32 PM > To: edk2-devel@lists.01.org; tim.lewis@insyde.com; Supreeth Venkatesh > Cc: michael.d.kinney@intel.com; liming.gao@intel.com > Subject: RE: [edk2] [PATCH v1 1/1] MdePkg/Include: Add management mode FV= file type and depex. >=20 > Hey Tim and Supreeth, >=20 > Sorry, 0x0C was a typo, 0x0D is the correct one. > The values of the SMM and MM constants are identical, this is just a nami= ng update plus the introduction of the new value, MM > Standalone Core, so backwards-compatibility is given. > Regarding the traditional MM Core, I just assumed it was an oversight as = MdePkg is generic. If it wasn't, sorry. >=20 > Thanks, > Marvin >=20 > > -----Original Message----- > > From: Tim Lewis [mailto:tim.lewis@insyde.com] > > Sent: Thursday, January 25, 2018 6:53 PM > > To: 'Supreeth Venkatesh' ; 'Marvin H?user' > > ; edk2-devel@lists.01.org > > Cc: michael.d.kinney@intel.com; liming.gao@intel.com > > Subject: RE: [edk2] [PATCH v1 1/1] MdePkg/Include: Add management mode > > FV file type and depex. > > > > Supreeth -- > > > > Doesn't Appendix A of the PI 1.6 define this as: > > > > #define EFI_FV_FILETYPE_SMM EFI_FV_FILETYPE_MM #define > > EFI_FV_FILETYPE_SMM_CORE EFI_FV_FILETYPE_MM_CORE > > > > Thanks, > > > > Tim > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > > Supreeth Venkatesh > > Sent: Thursday, January 25, 2018 9:45 AM > > To: Marvin H?user ; edk2- > > devel@lists.01.org > > Cc: michael.d.kinney@intel.com; liming.gao@intel.com > > Subject: Re: [edk2] [PATCH v1 1/1] MdePkg/Include: Add management mode > > FV file type and depex. > > > > Marvin, > > > > Thanks for your comments. > > As per PI v1.6 specification, > > EFI_FV_FILETYPE_MM_CORE value is 0x0D (MM Foundation that support MM > > Traditional Mode.) > > > > This is traditional MM mode, which ARM is not supporting at this > > point. We are more interested in MM_CORE_STANDALONE mode. > > However, I have no issues in adding this in the patch, but would > > prefer if this is added when MM traditional mode is supported in ARM. > > > > Further, > > w.r.t defining *_SMM_* definitions via the *_MM_* definitions. I don't > > want to break backwards compatibility with existing SMM traditional > > mode implementations. > > I will be happy to let folks who have migrated to _MM_ definitions > > from _SMM_ definitions to send the patch across. > > > > Thanks, > > Supreeth > > > > -----Original Message----- > > From: Marvin H?user [mailto:Marvin.Haeuser@outlook.com] > > Sent: Tuesday, January 23, 2018 6:34 PM > > To: edk2-devel@lists.01.org > > Cc: Supreeth Venkatesh ; > > michael.d.kinney@intel.com; liming.gao@intel.com > > Subject: RE: [edk2] [PATCH v1 1/1] MdePkg/Include: Add management mode > > FV file type and depex. > > > > Good day, > > > > I noticed this patch lacks the definition of "EFI_FV_FILETYPE_MM_CORE" > > (0x0C). > > Furthermore, may I suggest changing the *_SMM_* definitions to be > > defined via the *_MM_* definitions? > > > > Best regards, > > Marvin. > > > > > -----Original Message----- > > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf > > > Of Supreeth Venkatesh > > > Sent: Tuesday, January 23, 2018 9:03 PM > > > To: edk2-devel@lists.01.org > > > Cc: michael.d.kinney@intel.com; liming.gao@intel.com > > > Subject: [edk2] [PATCH v1 1/1] MdePkg/Include: Add management mode > > FV > > > file type and depex. > > > > > > As per PI specification v1.6, > > > The following new file types are added: > > > EFI_FV_FILETYPE_MM_STANDALONE > > > EFI_FV_FILETYPE_MM_CORE_STANDALONE > > > > > > The following new section type is added: > > > EFI_SECTION_MM_DEPEX > > > > > > This patch adds the management mode FV file type and depex. > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Signed-off-by: Achin Gupta > > > Signed-off-by: Supreeth Venkatesh > > > Reviewed-by: Jiewen Yao > > > --- > > > MdePkg/Include/Pi/PiFirmwareFile.h | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/MdePkg/Include/Pi/PiFirmwareFile.h > > > b/MdePkg/Include/Pi/PiFirmwareFile.h > > > index b982c9eda3..6086d1bb2f 100644 > > > --- a/MdePkg/Include/Pi/PiFirmwareFile.h > > > +++ b/MdePkg/Include/Pi/PiFirmwareFile.h > > > @@ -72,9 +72,12 @@ typedef UINT8 EFI_FFS_FILE_STATE; #define > > > EFI_FV_FILETYPE_COMBINED_PEIM_DRIVER 0x08 > > > #define EFI_FV_FILETYPE_APPLICATION 0x09 > > > #define EFI_FV_FILETYPE_SMM 0x0A > > > +#define EFI_FV_FILETYPE_MM 0x0A > > > #define EFI_FV_FILETYPE_FIRMWARE_VOLUME_IMAGE 0x0B > > > #define EFI_FV_FILETYPE_COMBINED_SMM_DXE 0x0C > > > +#define EFI_FV_FILETYPE_COMBINED_MM_DXE 0x0C > > > #define EFI_FV_FILETYPE_SMM_CORE 0x0D > > > +#define EFI_FV_FILETYPE_MM_STANDALONE 0x0E > > > #define EFI_FV_FILETYPE_OEM_MIN 0xc0 > > > #define EFI_FV_FILETYPE_OEM_MAX 0xdf > > > #define EFI_FV_FILETYPE_DEBUG_MIN 0xe0 > > > @@ -218,6 +221,7 @@ typedef UINT8 EFI_SECTION_TYPE; > > > #define EFI_SECTION_RAW 0x19 > > > #define EFI_SECTION_PEI_DEPEX 0x1B > > > #define EFI_SECTION_SMM_DEPEX 0x1C > > > +#define EFI_SECTION_MM_DEPEX 0x1C > > > > > > /// > > > /// Common section header. > > > -- > > > 2.14.1 > > > > > > _______________________________________________ > > > edk2-devel mailing list > > > edk2-devel@lists.01.org > > > https://lists.01.org/mailman/listinfo/edk2-devel > > IMPORTANT NOTICE: The contents of this email and any attachments are > > confidential and may also be privileged. If you are not the intended > > recipient, please notify the sender immediately and do not disclose > > the contents to any other person, use it for any purpose, or store or > > copy the information in any medium. Thank you. > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel >=20 > IMPORTANT NOTICE: The contents of this email and any attachments are conf= idential and may also be privileged. If you are not the > intended recipient, please notify the sender immediately and do not discl= ose the contents to any other person, use it for any purpose, > or store or copy the information in any medium. Thank you.