From: "Gao, Liming" <liming.gao@intel.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"Shaw, Kevin W" <kevin.w.shaw@intel.com>
Subject: Re: [Patch] DSC spec: Update Skuid value to support Hex number
Date: Wed, 31 Jan 2018 09:00:33 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1B9E2F@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1516677460-9832-1-git-send-email-yonghong.zhu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: Zhu, Yonghong
>Sent: Tuesday, January 23, 2018 11:18 AM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming <liming.gao@intel.com>; Kinney, Michael D
><michael.d.kinney@intel.com>; Shaw, Kevin W <kevin.w.shaw@intel.com>
>Subject: [Patch] DSC spec: Update Skuid value to support Hex number
>
>Original Skuid value only support to use integer, this patch extend it
>to also support hex number.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Michael Kinney <michael.d.kinney@intel.com>
>Cc: Kevin W Shaw <kevin.w.shaw@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
>---
> 2_dsc_overview/25_[skuids]_section_processing.md | 2 +-
> 3_edk_ii_dsc_file_format/37_[skuids]_section.md | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/2_dsc_overview/25_[skuids]_section_processing.md
>b/2_dsc_overview/25_[skuids]_section_processing.md
>index 428f7cf..afd102e 100644
>--- a/2_dsc_overview/25_[skuids]_section_processing.md
>+++ b/2_dsc_overview/25_[skuids]_section_processing.md
>@@ -35,11 +35,11 @@ The contents of this section are used to define valid
>`SKUID_IDENTIFIER` names.
> Since a platform may support different SKUs, and different SKUs may
>implement
> different methods for handing platform configuration data (PCD) the user can
> define, in this section, tag names to use. Use `0` for the `DEFAULT` SKU
> identifier. Each entry below the section header is of the form:
>
>-`integer | word`
>+`Number | word`
>
> The following is an example of a `[SkuIds]` section:
>
> ```
> [SkuIds]
>diff --git a/3_edk_ii_dsc_file_format/37_[skuids]_section.md
>b/3_edk_ii_dsc_file_format/37_[skuids]_section.md
>index 97642e9..756ded2 100644
>--- a/3_edk_ii_dsc_file_format/37_[skuids]_section.md
>+++ b/3_edk_ii_dsc_file_format/37_[skuids]_section.md
>@@ -42,18 +42,18 @@ recommended that a ".txt" extension be used.
>
> If this section is not specified, the parsing tools will assume a SkuId of 0,
> with a `UiName` of "DEFAULT". The default entry must not be re-defined.
>
> The `!include` file can only contain an ASCII (not Unicode) list of
>-"integer|UiSkuName" statements.
>+"Number|UiSkuName" statements.
>
> #### Prototype
>
> ```c
> <SkuId> ::= "[SkuIds]" <EOL>
> {<Statement>*} {<IncludeStatement>}
>-<Statement> ::= <TS> <Integer> <FS> <UiName> <EOL>
>+<Statement> ::= <TS> <Number> <FS> <UiName> <EOL>
> <UiName> ::= <Word>
> ```
>
> #### Example
>
>--
>2.6.1.windows.1
prev parent reply other threads:[~2018-01-31 8:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 3:17 [Patch] DSC spec: Update Skuid value to support Hex number Yonghong Zhu
2018-01-31 9:00 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E1B9E2F@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox