public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [Patch] DSC spec: Update Skuid value to support Hex number
@ 2018-01-23  3:17 Yonghong Zhu
  2018-01-31  9:00 ` Gao, Liming
  0 siblings, 1 reply; 2+ messages in thread
From: Yonghong Zhu @ 2018-01-23  3:17 UTC (permalink / raw)
  To: edk2-devel; +Cc: Liming Gao, Michael Kinney, Kevin W Shaw

Original Skuid value only support to use integer, this patch extend it
to also support hex number.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
Cc: Kevin W Shaw <kevin.w.shaw@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
---
 2_dsc_overview/25_[skuids]_section_processing.md | 2 +-
 3_edk_ii_dsc_file_format/37_[skuids]_section.md  | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/2_dsc_overview/25_[skuids]_section_processing.md b/2_dsc_overview/25_[skuids]_section_processing.md
index 428f7cf..afd102e 100644
--- a/2_dsc_overview/25_[skuids]_section_processing.md
+++ b/2_dsc_overview/25_[skuids]_section_processing.md
@@ -35,11 +35,11 @@ The contents of this section are used to define valid `SKUID_IDENTIFIER` names.
 Since a platform may support different SKUs, and different SKUs may implement
 different methods for handing platform configuration data (PCD) the user can
 define, in this section, tag names to use. Use `0` for the `DEFAULT` SKU
 identifier. Each entry below the section header is of the form:
 
-`integer | word`
+`Number | word`
 
 The following is an example of a `[SkuIds]` section:
 
 ```
 [SkuIds]
diff --git a/3_edk_ii_dsc_file_format/37_[skuids]_section.md b/3_edk_ii_dsc_file_format/37_[skuids]_section.md
index 97642e9..756ded2 100644
--- a/3_edk_ii_dsc_file_format/37_[skuids]_section.md
+++ b/3_edk_ii_dsc_file_format/37_[skuids]_section.md
@@ -42,18 +42,18 @@ recommended that a ".txt" extension be used.
 
 If this section is not specified, the parsing tools will assume a SkuId of 0,
 with a `UiName` of "DEFAULT". The default entry must not be re-defined.
 
 The `!include` file can only contain an ASCII (not Unicode) list of
-"integer|UiSkuName" statements.
+"Number|UiSkuName" statements.
 
 #### Prototype
 
 ```c
 <SkuId>     ::= "[SkuIds]" <EOL>
                 {<Statement>*} {<IncludeStatement>}
-<Statement> ::= <TS> <Integer> <FS> <UiName> <EOL>
+<Statement> ::= <TS> <Number> <FS> <UiName> <EOL>
 <UiName>    ::= <Word>
 ```
 
 #### Example
 
-- 
2.6.1.windows.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Patch] DSC spec: Update Skuid value to support Hex number
  2018-01-23  3:17 [Patch] DSC spec: Update Skuid value to support Hex number Yonghong Zhu
@ 2018-01-31  9:00 ` Gao, Liming
  0 siblings, 0 replies; 2+ messages in thread
From: Gao, Liming @ 2018-01-31  9:00 UTC (permalink / raw)
  To: Zhu, Yonghong, edk2-devel@lists.01.org; +Cc: Kinney, Michael D, Shaw, Kevin W

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Zhu, Yonghong
>Sent: Tuesday, January 23, 2018 11:18 AM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming <liming.gao@intel.com>; Kinney, Michael D
><michael.d.kinney@intel.com>; Shaw, Kevin W <kevin.w.shaw@intel.com>
>Subject: [Patch] DSC spec: Update Skuid value to support Hex number
>
>Original Skuid value only support to use integer, this patch extend it
>to also support hex number.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Michael Kinney <michael.d.kinney@intel.com>
>Cc: Kevin W Shaw <kevin.w.shaw@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
>---
> 2_dsc_overview/25_[skuids]_section_processing.md | 2 +-
> 3_edk_ii_dsc_file_format/37_[skuids]_section.md  | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/2_dsc_overview/25_[skuids]_section_processing.md
>b/2_dsc_overview/25_[skuids]_section_processing.md
>index 428f7cf..afd102e 100644
>--- a/2_dsc_overview/25_[skuids]_section_processing.md
>+++ b/2_dsc_overview/25_[skuids]_section_processing.md
>@@ -35,11 +35,11 @@ The contents of this section are used to define valid
>`SKUID_IDENTIFIER` names.
> Since a platform may support different SKUs, and different SKUs may
>implement
> different methods for handing platform configuration data (PCD) the user can
> define, in this section, tag names to use. Use `0` for the `DEFAULT` SKU
> identifier. Each entry below the section header is of the form:
>
>-`integer | word`
>+`Number | word`
>
> The following is an example of a `[SkuIds]` section:
>
> ```
> [SkuIds]
>diff --git a/3_edk_ii_dsc_file_format/37_[skuids]_section.md
>b/3_edk_ii_dsc_file_format/37_[skuids]_section.md
>index 97642e9..756ded2 100644
>--- a/3_edk_ii_dsc_file_format/37_[skuids]_section.md
>+++ b/3_edk_ii_dsc_file_format/37_[skuids]_section.md
>@@ -42,18 +42,18 @@ recommended that a ".txt" extension be used.
>
> If this section is not specified, the parsing tools will assume a SkuId of 0,
> with a `UiName` of "DEFAULT". The default entry must not be re-defined.
>
> The `!include` file can only contain an ASCII (not Unicode) list of
>-"integer|UiSkuName" statements.
>+"Number|UiSkuName" statements.
>
> #### Prototype
>
> ```c
> <SkuId>     ::= "[SkuIds]" <EOL>
>                 {<Statement>*} {<IncludeStatement>}
>-<Statement> ::= <TS> <Integer> <FS> <UiName> <EOL>
>+<Statement> ::= <TS> <Number> <FS> <UiName> <EOL>
> <UiName>    ::= <Word>
> ```
>
> #### Example
>
>--
>2.6.1.windows.1



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-01-31  8:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-23  3:17 [Patch] DSC spec: Update Skuid value to support Hex number Yonghong Zhu
2018-01-31  9:00 ` Gao, Liming

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox