From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 37CA121D2BEF6 for ; Wed, 31 Jan 2018 00:55:02 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jan 2018 01:00:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,439,1511856000"; d="scan'208";a="23610707" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga003.jf.intel.com with ESMTP; 31 Jan 2018 01:00:37 -0800 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 31 Jan 2018 01:00:37 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 31 Jan 2018 01:00:36 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.127]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.192]) with mapi id 14.03.0319.002; Wed, 31 Jan 2018 17:00:34 +0800 From: "Gao, Liming" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , "Shaw, Kevin W" Thread-Topic: [Patch] DSC spec: Update Skuid value to support Hex number Thread-Index: AQHTk/jDsmxBK/yBQEGPBeE54NlmvKONu/PA Date: Wed, 31 Jan 2018 09:00:33 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1B9E2F@SHSMSX104.ccr.corp.intel.com> References: <1516677460-9832-1-git-send-email-yonghong.zhu@intel.com> In-Reply-To: <1516677460-9832-1-git-send-email-yonghong.zhu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] DSC spec: Update Skuid value to support Hex number X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Jan 2018 08:55:02 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: Zhu, Yonghong >Sent: Tuesday, January 23, 2018 11:18 AM >To: edk2-devel@lists.01.org >Cc: Gao, Liming ; Kinney, Michael D >; Shaw, Kevin W >Subject: [Patch] DSC spec: Update Skuid value to support Hex number > >Original Skuid value only support to use integer, this patch extend it >to also support hex number. > >Cc: Liming Gao >Cc: Michael Kinney >Cc: Kevin W Shaw >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Yonghong Zhu >--- > 2_dsc_overview/25_[skuids]_section_processing.md | 2 +- > 3_edk_ii_dsc_file_format/37_[skuids]_section.md | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/2_dsc_overview/25_[skuids]_section_processing.md >b/2_dsc_overview/25_[skuids]_section_processing.md >index 428f7cf..afd102e 100644 >--- a/2_dsc_overview/25_[skuids]_section_processing.md >+++ b/2_dsc_overview/25_[skuids]_section_processing.md >@@ -35,11 +35,11 @@ The contents of this section are used to define valid >`SKUID_IDENTIFIER` names. > Since a platform may support different SKUs, and different SKUs may >implement > different methods for handing platform configuration data (PCD) the user = can > define, in this section, tag names to use. Use `0` for the `DEFAULT` SKU > identifier. Each entry below the section header is of the form: > >-`integer | word` >+`Number | word` > > The following is an example of a `[SkuIds]` section: > > ``` > [SkuIds] >diff --git a/3_edk_ii_dsc_file_format/37_[skuids]_section.md >b/3_edk_ii_dsc_file_format/37_[skuids]_section.md >index 97642e9..756ded2 100644 >--- a/3_edk_ii_dsc_file_format/37_[skuids]_section.md >+++ b/3_edk_ii_dsc_file_format/37_[skuids]_section.md >@@ -42,18 +42,18 @@ recommended that a ".txt" extension be used. > > If this section is not specified, the parsing tools will assume a SkuId o= f 0, > with a `UiName` of "DEFAULT". The default entry must not be re-defined. > > The `!include` file can only contain an ASCII (not Unicode) list of >-"integer|UiSkuName" statements. >+"Number|UiSkuName" statements. > > #### Prototype > > ```c > ::=3D "[SkuIds]" > {*} {} >- ::=3D >+ ::=3D > ::=3D > ``` > > #### Example > >-- >2.6.1.windows.1