From: "Gao, Liming" <liming.gao@intel.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
"lersek@redhat.com" <lersek@redhat.com>
Subject: Re: [PATCH] BaseTools/build_rule: pass contents of DTC_FLAGS device tree compiler
Date: Thu, 1 Feb 2018 01:32:46 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1BA539@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20180131214909.1103-1-ard.biesheuvel@linaro.org>
Ard:
Do you consider to add DTC_FLAGS in tools_def.template file? Its value can be empty. So, user bases on tools_def.txt to know which option can be set.
>-----Original Message-----
>From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
>Sent: Thursday, February 01, 2018 5:49 AM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming <liming.gao@intel.com>; Zhu, Yonghong
><yonghong.zhu@intel.com>; lersek@redhat.com; Ard Biesheuvel
><ard.biesheuvel@linaro.org>
>Subject: [PATCH] BaseTools/build_rule: pass contents of DTC_FLAGS device
>tree compiler
>
>To allow device tree compilation to be customized at the platform or
>module level, pass the contents of the DTC_FLAGS variable on the
>dtc command line.
>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>---
> BaseTools/Conf/build_rule.template | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/BaseTools/Conf/build_rule.template
>b/BaseTools/Conf/build_rule.template
>index 3e6aa8ff0f34..a5e471eb3c10 100755
>--- a/BaseTools/Conf/build_rule.template
>+++ b/BaseTools/Conf/build_rule.template
>@@ -250,7 +250,7 @@
>
> <Command.GCC>
> "$(PP)" $(DTCPP_FLAGS) $(INC) ${src} > ${d_path}(+)${s_base}.i
>- "$(DTC)" -I dts -O dtb -o ${dst} ${d_path}(+)${s_base}.i
>+ "$(DTC)" $(DTC_FLAGS) -I dts -O dtb -o ${dst} ${d_path}(+)${s_base}.i
>
> [Visual-Form-Representation-File]
> <InputFile>
>--
>2.11.0
next prev parent reply other threads:[~2018-02-01 1:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 21:49 [PATCH] BaseTools/build_rule: pass contents of DTC_FLAGS device tree compiler Ard Biesheuvel
2018-02-01 1:32 ` Gao, Liming [this message]
2018-02-01 11:11 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E1BA539@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox