Re: [PATCH v2 1/1] MdePkg/Include: Add management mode FV file type and depex.

["Gao, Liming" <liming.gao@intel.com>]

Supreeth:
  Thanks for your update. PI spec doesn't define EFI_FV_FILETYPE_SMM_STANDALONE and EFI_FV_FILETYPE_SMM_CORE_STANDALONE. So, please remove them in this patch. 

Thanks
Liming
>-----Original Message-----
>From: Supreeth Venkatesh [mailto:supreeth.venkatesh@arm.com]
>Sent: Thursday, February 01, 2018 4:06 AM
>To: edk2-devel@lists.01.org
>Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
><liming.gao@intel.com>; Marvin.Haeuser@outlook.com;
>tim.lewis@insyde.com; Yao, Jiewen <jiewen.yao@intel.com>; Supreeth
>Venkatesh <supreeth.venkatesh@arm.com>; Achin Gupta
><achin.gupta@arm.com>
>Subject: [PATCH v2 1/1] MdePkg/Include: Add management mode FV file
>type and depex.
>
>As per PI specification v1.6,
>As per section 2.1.4.1,
>The following file types exist:
>Table 3. Defined File Types
>Name                                   Value
>EFI_FV_FILETYPE_RAW                    0x01
>EFI_FV_FILETYPE_FREEFORM               0x02
>EFI_FV_FILETYPE_SECURITY_CORE          0x03
>EFI_FV_FILETYPE_PEI_CORE               0x04
>EFI_FV_FILETYPE_DXE_CORE               0x05
>EFI_FV_FILETYPE_PEIM                   0x06
>EFI_FV_FILETYPE_DRIVER                 0x07
>EFI_FV_FILETYPE_COMBINED_PEIM_DRIVER   0x08
>EFI_FV_FILETYPE_APPLICATION            0x09
>EFI_FV_FILETYPE_MM                     0x0A
>EFI_FV_FILETYPE_FIRMWARE_VOLUME_IMAGE  0x0B
>EFI_FV_FILETYPE_COMBINED_MM_DXE        0x0C
>EFI_FV_FILETYPE_MM_CORE                0x0D
>EFI_FV_FILETYPE_MM_STANDALONE          0x0E
>EFI_FV_FILETYPE_MM_CORE_STANDALONE     0x0F
>
>The following new section type is added:
>EFI_SECTION_MM_DEPEX
>
>This patch adds the management mode FV file type and depex.
>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Achin Gupta <achin.gupta@arm.com>
>Signed-off-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
>Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
>---
> MdePkg/Include/Pi/PiFirmwareFile.h | 16 ++++++++++++----
> 1 file changed, 12 insertions(+), 4 deletions(-)
>
>diff --git a/MdePkg/Include/Pi/PiFirmwareFile.h
>b/MdePkg/Include/Pi/PiFirmwareFile.h
>index b982c9eda3..808202cd22 100644
>--- a/MdePkg/Include/Pi/PiFirmwareFile.h
>+++ b/MdePkg/Include/Pi/PiFirmwareFile.h
>@@ -71,10 +71,17 @@ typedef UINT8 EFI_FFS_FILE_STATE;
> #define EFI_FV_FILETYPE_DRIVER                0x07
> #define EFI_FV_FILETYPE_COMBINED_PEIM_DRIVER  0x08
> #define EFI_FV_FILETYPE_APPLICATION           0x09
>-#define EFI_FV_FILETYPE_SMM                   0x0A
>+#define EFI_FV_FILETYPE_MM                    0x0A
>+#define EFI_FV_FILETYPE_SMM                   EFI_FV_FILETYPE_MM
> #define EFI_FV_FILETYPE_FIRMWARE_VOLUME_IMAGE 0x0B
>-#define EFI_FV_FILETYPE_COMBINED_SMM_DXE      0x0C
>-#define EFI_FV_FILETYPE_SMM_CORE              0x0D
>+#define EFI_FV_FILETYPE_COMBINED_MM_DXE       0x0C
>+#define EFI_FV_FILETYPE_COMBINED_SMM_DXE
>EFI_FV_FILETYPE_COMBINED_MM_DXE
>+#define EFI_FV_FILETYPE_MM_CORE               0x0D
>+#define EFI_FV_FILETYPE_SMM_CORE              EFI_FV_FILETYPE_MM_CORE
>+#define EFI_FV_FILETYPE_MM_STANDALONE         0x0E
>+#define EFI_FV_FILETYPE_SMM_STANDALONE
>EFI_FV_FILETYPE_MM_STANDALONE
>+#define EFI_FV_FILETYPE_MM_CORE_STANDALONE    0x0F
>+#define EFI_FV_FILETYPE_SMM_CORE_STANDALONE
>EFI_FV_FILETYPE_MM_CORE_STANDALONE
> #define EFI_FV_FILETYPE_OEM_MIN               0xc0
> #define EFI_FV_FILETYPE_OEM_MAX               0xdf
> #define EFI_FV_FILETYPE_DEBUG_MIN             0xe0
>@@ -217,7 +224,8 @@ typedef UINT8 EFI_SECTION_TYPE;
> #define EFI_SECTION_FREEFORM_SUBTYPE_GUID 0x18
> #define EFI_SECTION_RAW                   0x19
> #define EFI_SECTION_PEI_DEPEX             0x1B
>-#define EFI_SECTION_SMM_DEPEX             0x1C
>+#define EFI_SECTION_MM_DEPEX              0x1C
>+#define EFI_SECTION_SMM_DEPEX             EFI_SECTION_MM_DEPEX
>
> ///
> /// Common section header.
>--
>2.14.1