From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DB71221F0DA6E for ; Tue, 6 Feb 2018 19:37:20 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Feb 2018 19:43:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,471,1511856000"; d="scan'208";a="25357329" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga003.jf.intel.com with ESMTP; 06 Feb 2018 19:43:03 -0800 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 6 Feb 2018 19:43:02 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 6 Feb 2018 19:43:02 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.125]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.116]) with mapi id 14.03.0319.002; Wed, 7 Feb 2018 11:43:01 +0800 From: "Gao, Liming" To: Supreeth Venkatesh , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , "Marvin.Haeuser@outlook.com" , "tim.lewis@insyde.com" , "Yao, Jiewen" , Achin Gupta Thread-Topic: [PATCH v2 1/1] MdePkg/Include: Add management mode FV file type and depex. Thread-Index: AQHTms77NCRi1CZUmkS737dTSuGX0aOYVRzQ Date: Wed, 7 Feb 2018 03:43:00 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1C8B14@SHSMSX104.ccr.corp.intel.com> References: <20180131200613.30710-1-supreeth.venkatesh@arm.com> In-Reply-To: <20180131200613.30710-1-supreeth.venkatesh@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 1/1] MdePkg/Include: Add management mode FV file type and depex. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Feb 2018 03:37:21 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Supreeth: Thanks for your update. PI spec doesn't define EFI_FV_FILETYPE_SMM_STANDA= LONE and EFI_FV_FILETYPE_SMM_CORE_STANDALONE. So, please remove them in thi= s patch.=20 Thanks Liming >-----Original Message----- >From: Supreeth Venkatesh [mailto:supreeth.venkatesh@arm.com] >Sent: Thursday, February 01, 2018 4:06 AM >To: edk2-devel@lists.01.org >Cc: Kinney, Michael D ; Gao, Liming >; Marvin.Haeuser@outlook.com; >tim.lewis@insyde.com; Yao, Jiewen ; Supreeth >Venkatesh ; Achin Gupta > >Subject: [PATCH v2 1/1] MdePkg/Include: Add management mode FV file >type and depex. > >As per PI specification v1.6, >As per section 2.1.4.1, >The following file types exist: >Table 3. Defined File Types >Name Value >EFI_FV_FILETYPE_RAW 0x01 >EFI_FV_FILETYPE_FREEFORM 0x02 >EFI_FV_FILETYPE_SECURITY_CORE 0x03 >EFI_FV_FILETYPE_PEI_CORE 0x04 >EFI_FV_FILETYPE_DXE_CORE 0x05 >EFI_FV_FILETYPE_PEIM 0x06 >EFI_FV_FILETYPE_DRIVER 0x07 >EFI_FV_FILETYPE_COMBINED_PEIM_DRIVER 0x08 >EFI_FV_FILETYPE_APPLICATION 0x09 >EFI_FV_FILETYPE_MM 0x0A >EFI_FV_FILETYPE_FIRMWARE_VOLUME_IMAGE 0x0B >EFI_FV_FILETYPE_COMBINED_MM_DXE 0x0C >EFI_FV_FILETYPE_MM_CORE 0x0D >EFI_FV_FILETYPE_MM_STANDALONE 0x0E >EFI_FV_FILETYPE_MM_CORE_STANDALONE 0x0F > >The following new section type is added: >EFI_SECTION_MM_DEPEX > >This patch adds the management mode FV file type and depex. > >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Achin Gupta >Signed-off-by: Supreeth Venkatesh >Reviewed-by: Jiewen Yao >--- > MdePkg/Include/Pi/PiFirmwareFile.h | 16 ++++++++++++---- > 1 file changed, 12 insertions(+), 4 deletions(-) > >diff --git a/MdePkg/Include/Pi/PiFirmwareFile.h >b/MdePkg/Include/Pi/PiFirmwareFile.h >index b982c9eda3..808202cd22 100644 >--- a/MdePkg/Include/Pi/PiFirmwareFile.h >+++ b/MdePkg/Include/Pi/PiFirmwareFile.h >@@ -71,10 +71,17 @@ typedef UINT8 EFI_FFS_FILE_STATE; > #define EFI_FV_FILETYPE_DRIVER 0x07 > #define EFI_FV_FILETYPE_COMBINED_PEIM_DRIVER 0x08 > #define EFI_FV_FILETYPE_APPLICATION 0x09 >-#define EFI_FV_FILETYPE_SMM 0x0A >+#define EFI_FV_FILETYPE_MM 0x0A >+#define EFI_FV_FILETYPE_SMM EFI_FV_FILETYPE_MM > #define EFI_FV_FILETYPE_FIRMWARE_VOLUME_IMAGE 0x0B >-#define EFI_FV_FILETYPE_COMBINED_SMM_DXE 0x0C >-#define EFI_FV_FILETYPE_SMM_CORE 0x0D >+#define EFI_FV_FILETYPE_COMBINED_MM_DXE 0x0C >+#define EFI_FV_FILETYPE_COMBINED_SMM_DXE >EFI_FV_FILETYPE_COMBINED_MM_DXE >+#define EFI_FV_FILETYPE_MM_CORE 0x0D >+#define EFI_FV_FILETYPE_SMM_CORE EFI_FV_FILETYPE_MM_CORE >+#define EFI_FV_FILETYPE_MM_STANDALONE 0x0E >+#define EFI_FV_FILETYPE_SMM_STANDALONE >EFI_FV_FILETYPE_MM_STANDALONE >+#define EFI_FV_FILETYPE_MM_CORE_STANDALONE 0x0F >+#define EFI_FV_FILETYPE_SMM_CORE_STANDALONE >EFI_FV_FILETYPE_MM_CORE_STANDALONE > #define EFI_FV_FILETYPE_OEM_MIN 0xc0 > #define EFI_FV_FILETYPE_OEM_MAX 0xdf > #define EFI_FV_FILETYPE_DEBUG_MIN 0xe0 >@@ -217,7 +224,8 @@ typedef UINT8 EFI_SECTION_TYPE; > #define EFI_SECTION_FREEFORM_SUBTYPE_GUID 0x18 > #define EFI_SECTION_RAW 0x19 > #define EFI_SECTION_PEI_DEPEX 0x1B >-#define EFI_SECTION_SMM_DEPEX 0x1C >+#define EFI_SECTION_MM_DEPEX 0x1C >+#define EFI_SECTION_SMM_DEPEX EFI_SECTION_MM_DEPEX > > /// > /// Common section header. >-- >2.14.1