From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.136; helo=mga12.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C5C2622361E4C for ; Wed, 7 Feb 2018 18:43:44 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Feb 2018 18:49:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,476,1511856000"; d="scan'208";a="25627688" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga003.jf.intel.com with ESMTP; 07 Feb 2018 18:49:28 -0800 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 7 Feb 2018 18:49:28 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 7 Feb 2018 18:49:27 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.125]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.116]) with mapi id 14.03.0319.002; Thu, 8 Feb 2018 10:49:26 +0800 From: "Gao, Liming" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch] BaseTools: not specified value of MAX_CONCURRENT_THREAD_NUMBER Thread-Index: AQHToH82Na5WjT0nFUqi9x4sETMviaOZzdmA Date: Thu, 8 Feb 2018 02:49:25 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1C98F9@SHSMSX104.ccr.corp.intel.com> References: <1518054622-8640-1-git-send-email-yonghong.zhu@intel.com> In-Reply-To: <1518054622-8640-1-git-send-email-yonghong.zhu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools: not specified value of MAX_CONCURRENT_THREAD_NUMBER X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Feb 2018 02:43:45 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Thursday, February 08, 2018 9:50 AM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch] BaseTools: not specified value of >MAX_CONCURRENT_THREAD_NUMBER > >V3: Update the build option help info > >when MAX_CONCURRENT_THREAD_NUMBER is not specified, tool will >automatically detect number of processor threads. > >Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=3D775 >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Yonghong Zhu >--- > BaseTools/Conf/target.template | 14 +++++++++----- > BaseTools/Source/Python/build/build.py | 3 ++- > 2 files changed, 11 insertions(+), 6 deletions(-) > >diff --git a/BaseTools/Conf/target.template >b/BaseTools/Conf/target.template >index 787fc64..e5c31fe 100644 >--- a/BaseTools/Conf/target.template >+++ b/BaseTools/Conf/target.template >@@ -1,7 +1,7 @@ > # >-# Copyright (c) 2006 - 2011, Intel Corporation. All rights reserved.
>+# Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
> # > # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the = BSD >License > # which accompanies this distribution. The full text of the license may= be >found at > # http://opensource.org/licenses/bsd-license.php >@@ -57,14 +57,18 @@ TOOL_CHAIN_CONF =3D Conf/tools_def.txt > # TAGNAME List Optional Specify the name(s) of the = tools_def.txt >TagName to use. > # If not specified, all appli= cable TagName tools will be > # used for the build. The li= st uses space character >separation. > TOOL_CHAIN_TAG =3D MYTOOLS > >-# MAX_CONCURRENT_THREAD_NUMBER NUMBER Optional The number >of concurrent threads. Recommend to set this >-# value to one more than = the number of your >compurter >-# cores or CPUs. Less tha= n 2 means disable >multithread build. >-MAX_CONCURRENT_THREAD_NUMBER =3D 1 >+# MAX_CONCURRENT_THREAD_NUMBER NUMBER Optional The number >of concurrent threads. If not specified or set >+# to zero, tool automatic= ally detect number of >processor >+# threads. Recommend to s= et this value to one less >than the >+# number of your computer= cores or CPUs. When >value set to 1, >+# means disable multi-thr= ead build, value set to >more than 1, >+# means user specify the = thread number to build. >Not specify >+# the default value in th= is file. >+# MAX_CONCURRENT_THREAD_NUMBER =3D 1 > > > # BUILD_RULE_CONF Filename Optional Specify the file name to use for th= e >build rules that are followed > # when generating Makefiles. If not s= pecified, the file: > # WORKSPACE/Conf/build_rule.txt will = be used >diff --git a/BaseTools/Source/Python/build/build.py >b/BaseTools/Source/Python/build/build.py >index 24f9962..06a89ed 100644 >--- a/BaseTools/Source/Python/build/build.py >+++ b/BaseTools/Source/Python/build/build.py >@@ -2321,11 +2321,12 @@ def MyOptionParser(): > help=3D"Using the Tool Chain Tagname to build the platform, overr= iding >target.txt's TOOL_CHAIN_TAG definition.") > Parser.add_option("-x", "--sku-id", action=3D"callback", type=3D"stri= ng", >dest=3D"SkuId", callback=3DSingleCheckCallback, > help=3D"Using this name of SKU ID to build the platform, overridi= ng >SKUID_IDENTIFIER in DSC file.") > > Parser.add_option("-n", action=3D"callback", type=3D"int", >dest=3D"ThreadNumber", callback=3DSingleCheckCallback, >- help=3D"Build the platform using multi-threaded compiler. The val= ue >overrides target.txt's MAX_CONCURRENT_THREAD_NUMBER. Less than 2 will >disable multi-thread builds.") >+ help=3D"Build the platform using multi-threaded compiler. The val= ue >overrides target.txt's MAX_CONCURRENT_THREAD_NUMBER. When value is >set to 0, tool automatically detect number of "\ >+ "processor threads, set value to 1 means disable multi-threa= d build, >and set value more than 1 means user specify the threads number to build.= ") > > Parser.add_option("-f", "--fdf", action=3D"callback", type=3D"string"= , >dest=3D"FdfFile", callback=3DSingleCheckCallback, > help=3D"The name of the FDF file to use, which overrides the sett= ing in the >DSC file.") > Parser.add_option("-r", "--rom-image", action=3D"append", type=3D"str= ing", >dest=3D"RomImage", default=3D[], > help=3D"The name of FD to be generated. The name must be from [FD= ] >section in FDF file.") >-- >2.6.1.windows.1 > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel