From: "Gao, Liming" <liming.gao@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Wu, Hao A" <hao.a.wu@intel.com>
Subject: Re: [patch 1/2] ShellPkg/Dp: Add null pointer check
Date: Fri, 9 Feb 2018 06:57:08 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1CAD0E@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1518145812-14188-1-git-send-email-dandan.bi@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: Bi, Dandan
>Sent: Friday, February 09, 2018 11:10 AM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming <liming.gao@intel.com>; Wu, Hao A <hao.a.wu@intel.com>
>Subject: [patch 1/2] ShellPkg/Dp: Add null pointer check
>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Hao Wu <hao.a.wu@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Dandan Bi <dandan.bi@intel.com>
>---
> ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
>b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
>index fafc64f..4dd7dd9 100644
>--- a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
>+++ b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
>@@ -255,11 +255,11 @@ GetBootPerformanceTable (
> Status = EfiGetSystemConfigurationTable (
> &gEfiAcpi10TableGuid,
> &AcpiTable
> );
> }
>- if (EFI_ERROR(Status)) {
>+ if (EFI_ERROR(Status) || AcpiTable == NULL) {
> return Status;
> }
>
> FirmwarePerformanceTable = FindAcpiPtr (
> (EFI_ACPI_5_0_ROOT_SYSTEM_DESCRIPTION_POINTER
>*)AcpiTable,
>--
>1.9.5.msysgit.1
prev parent reply other threads:[~2018-02-09 6:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 3:10 [patch 1/2] ShellPkg/Dp: Add null pointer check Dandan Bi
2018-02-09 3:10 ` [patch 2/2] ShellPkg/DP: Update the error message info Dandan Bi
2018-02-09 6:57 ` Gao, Liming
2018-02-09 6:57 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E1CAD0E@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox