From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B4312223DB79E for ; Thu, 8 Feb 2018 22:51:43 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Feb 2018 22:57:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,482,1511856000"; d="scan'208";a="33347809" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga002.jf.intel.com with ESMTP; 08 Feb 2018 22:57:28 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 8 Feb 2018 22:57:28 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.125]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.253]) with mapi id 14.03.0319.002; Fri, 9 Feb 2018 14:57:26 +0800 From: "Gao, Liming" To: "Bi, Dandan" , "edk2-devel@lists.01.org" CC: "Yao, Jiewen" Thread-Topic: [edk2] [patch 2/2] ShellPkg/DP: Update the error message info Thread-Index: AQHToVOiw7JwAZlEe0mSxeEzmjGP5KObo8oA Date: Fri, 9 Feb 2018 06:57:26 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1CAD1E@SHSMSX104.ccr.corp.intel.com> References: <1518145812-14188-1-git-send-email-dandan.bi@intel.com> <1518145812-14188-2-git-send-email-dandan.bi@intel.com> In-Reply-To: <1518145812-14188-2-git-send-email-dandan.bi@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch 2/2] ShellPkg/DP: Update the error message info X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Feb 2018 06:51:44 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >Dandan Bi >Sent: Friday, February 09, 2018 11:10 AM >To: edk2-devel@lists.01.org >Cc: Yao, Jiewen ; Gao, Liming >Subject: [edk2] [patch 2/2] ShellPkg/DP: Update the error message info > >Make the error message clearer if fail to get ACPI/FPDT table. > >Cc: Liming Gao >Cc: Jiewen Yao >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Dandan Bi >--- > ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c | 3 ++- > ShellPkg/DynamicCommand/DpDynamicCommand/Dp.uni | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > >diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c >b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c >index 4dd7dd9..aa9c2cd 100644 >--- a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c >+++ b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c >@@ -256,18 +256,20 @@ GetBootPerformanceTable ( > &gEfiAcpi10TableGuid, > &AcpiTable > ); > } > if (EFI_ERROR(Status) || AcpiTable =3D=3D NULL) { >+ ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN >(STR_DP_GET_ACPI_TABLE_FAIL), mDpHiiHandle); > return Status; > } > > FirmwarePerformanceTable =3D FindAcpiPtr ( > (EFI_ACPI_5_0_ROOT_SYSTEM_DESCRIPTION_POINTER >*)AcpiTable, > >EFI_ACPI_5_0_FIRMWARE_PERFORMANCE_DATA_TABLE_SIGNATURE > ); > if (FirmwarePerformanceTable =3D=3D NULL) { >+ ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN >(STR_DP_GET_ACPI_FPDT_FAIL), mDpHiiHandle); > return EFI_NOT_FOUND; > } > > mBootPerformanceTable =3D (UINT8*) (UINTN)FirmwarePerformanceTable- >>BootPointerRecord.BootPerformanceTablePointer; > mBootPerformanceTableSize =3D ((BOOT_PERFORMANCE_TABLE *) >mBootPerformanceTable)->Header.Length; >@@ -737,11 +739,10 @@ RunDp ( > // > //1. Get FPDT from ACPI table. > // > Status =3D GetBootPerformanceTable (); > if (EFI_ERROR(Status)) { >- ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN >(STR_DP_GET_BOOT_PERFORMANCE_TABLE_FAIL), mDpHiiHandle); > return Status; > } > > // > //2. Cache the ModuleGuid and hanlde mapping table. >diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.uni >b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.uni >index b6069ae..c7eb0fb 100644 >--- a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.uni >+++ b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.uni >@@ -88,11 +88,12 @@ > #string STR_DP_RAW_VARS2 #language en-US >"%5d: %16LX %16LX %16LX %31a %31a %5d\n" > #string STR_DP_RAW_HEADR2 #language en-US "\nIndex Ha= ndle >Start Count End Count Token = Module ID\n" > #string STR_DP_INCOMPLETE #language en-US " I " > #string STR_DP_COMPLETE #language en-US " " > #string STR_ALIT_UNKNOWN #language en-US "Unknown" >-#string STR_DP_GET_BOOT_PERFORMANCE_TABLE_FAIL #language en- >US "Fail to get boot performance table\n" >+#string STR_DP_GET_ACPI_TABLE_FAIL #language en-US "Fail to get ACPI >Table\n" >+#string STR_DP_GET_ACPI_FPDT_FAIL #language en-US "Fail to get >Firmware Performance Data Table (FPDT) in ACPI Table\n" > > #string STR_GET_HELP_DP #language en-US "" > ".TH dp 0 "Display performance metrics"\r\n" > ".SH NAME\r\n" > "Displays performance metrics that are stored in memory.\r\n" >-- >1.9.5.msysgit.1 > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel