From: "Gao, Liming" <liming.gao@intel.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTools: Add WindowsLike path in front of PATH Env
Date: Fri, 23 Feb 2018 07:25:39 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1CEC6E@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1519266696-27124-1-git-send-email-yonghong.zhu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Yonghong Zhu
>Sent: Thursday, February 22, 2018 10:32 AM
>To: edk2-devel@lists.01.org
>Subject: [edk2] [Patch] BaseTools: Add WindowsLike path in front of PATH Env
>
>Original BaseTools source build append WindowsLike path to PATH Env,
>while WINDDK installation has a "build.exe", if user place WINDDK
>folder to PATH either during WINDDK installation or manually, it will
>block the BaseTools' build.bat.
>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
>---
> BaseTools/toolsetup.bat | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/BaseTools/toolsetup.bat b/BaseTools/toolsetup.bat
>index 51c2760..562f993 100755
>--- a/BaseTools/toolsetup.bat
>+++ b/BaseTools/toolsetup.bat
>@@ -315,11 +315,11 @@ goto end
> if not defined PYTHON_FREEZER_PATH (
> echo.
> echo !!! WARNING !!! PYTHON_FREEZER_PATH environment variable is not
>set.
> echo Setup environment to run Python scripts directly.
> echo.
>- set "PATH=%PATH%;%BASE_TOOLS_PATH%\BinWrappers\WindowsLike"
>+ set "PATH=%BASE_TOOLS_PATH%\BinWrappers\WindowsLike;%PATH%"
> )
>
> set BASETOOLS_PYTHON_SOURCE=%BASE_TOOLS_PATH%\Source\Python
> set PYTHONPATH=%BASETOOLS_PYTHON_SOURCE%;%PYTHONPATH%
>
>--
>2.6.1.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2018-02-23 7:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 2:31 [Patch] BaseTools: Add WindowsLike path in front of PATH Env Yonghong Zhu
2018-02-23 7:25 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E1CEC6E@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox