From: "Gao, Liming" <liming.gao@intel.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTools: Fix the bug to display the single SKUID info
Date: Fri, 23 Feb 2018 09:43:35 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1CEE7F@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1519179005-24128-1-git-send-email-yonghong.zhu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Yonghong Zhu
>Sent: Wednesday, February 21, 2018 10:10 AM
>To: edk2-devel@lists.01.org
>Subject: [edk2] [Patch] BaseTools: Fix the bug to display the single SKUID info
>
>when defined SKUID_IDENTIFIER = DEFAULT|TEST in DSC [Defines] section,
>per spec it means current SKUID is single, the bug is build report print
>both DEFAULT and TEST info, it should only print TEST.
>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
>---
> BaseTools/Source/Python/Common/Misc.py | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/BaseTools/Source/Python/Common/Misc.py
>b/BaseTools/Source/Python/Common/Misc.py
>index b13e35c..1461d00 100644
>--- a/BaseTools/Source/Python/Common/Misc.py
>+++ b/BaseTools/Source/Python/Common/Misc.py
>@@ -2237,10 +2237,14 @@ class SkuClass():
> self.AvailableSkuIds.update({'DEFAULT':0, 'COMMON':0})
> if self.SkuIdSet:
> GlobalData.gSkuids = (self.SkuIdSet)
> if 'COMMON' in GlobalData.gSkuids:
> GlobalData.gSkuids.remove('COMMON')
>+ if self.SkuUsageType == self.SINGLE:
>+ if len(GlobalData.gSkuids) != 1:
>+ if 'DEFAULT' in GlobalData.gSkuids:
>+ GlobalData.gSkuids.remove('DEFAULT')
> if GlobalData.gSkuids:
> GlobalData.gSkuids.sort()
>
> def GetNextSkuId(self, skuname):
> if not self.__SkuInherit:
>--
>2.6.1.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2018-02-23 9:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 2:10 [Patch] BaseTools: Fix the bug to display the single SKUID info Yonghong Zhu
2018-02-23 9:43 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E1CEE7F@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox