From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 998792243693B for ; Fri, 23 Feb 2018 01:37:37 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Feb 2018 01:43:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,382,1515484800"; d="scan'208";a="32996769" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga001.fm.intel.com with ESMTP; 23 Feb 2018 01:43:38 -0800 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 23 Feb 2018 01:43:37 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 23 Feb 2018 01:43:37 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.125]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.116]) with mapi id 14.03.0319.002; Fri, 23 Feb 2018 17:43:36 +0800 From: "Gao, Liming" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch] BaseTools: Fix the bug to display the single SKUID info Thread-Index: AQHTqrkrXB89ub4D3EqqL9h3T6dBFqOxwBdw Date: Fri, 23 Feb 2018 09:43:35 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1CEE7F@SHSMSX104.ccr.corp.intel.com> References: <1519179005-24128-1-git-send-email-yonghong.zhu@intel.com> In-Reply-To: <1519179005-24128-1-git-send-email-yonghong.zhu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools: Fix the bug to display the single SKUID info X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Feb 2018 09:37:38 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Wednesday, February 21, 2018 10:10 AM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch] BaseTools: Fix the bug to display the single SKUID= info > >when defined SKUID_IDENTIFIER =3D DEFAULT|TEST in DSC [Defines] section, >per spec it means current SKUID is single, the bug is build report print >both DEFAULT and TEST info, it should only print TEST. > >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Yonghong Zhu >--- > BaseTools/Source/Python/Common/Misc.py | 4 ++++ > 1 file changed, 4 insertions(+) > >diff --git a/BaseTools/Source/Python/Common/Misc.py >b/BaseTools/Source/Python/Common/Misc.py >index b13e35c..1461d00 100644 >--- a/BaseTools/Source/Python/Common/Misc.py >+++ b/BaseTools/Source/Python/Common/Misc.py >@@ -2237,10 +2237,14 @@ class SkuClass(): > self.AvailableSkuIds.update({'DEFAULT':0, 'COMMON':0}) > if self.SkuIdSet: > GlobalData.gSkuids =3D (self.SkuIdSet) > if 'COMMON' in GlobalData.gSkuids: > GlobalData.gSkuids.remove('COMMON') >+ if self.SkuUsageType =3D=3D self.SINGLE: >+ if len(GlobalData.gSkuids) !=3D 1: >+ if 'DEFAULT' in GlobalData.gSkuids: >+ GlobalData.gSkuids.remove('DEFAULT') > if GlobalData.gSkuids: > GlobalData.gSkuids.sort() > > def GetNextSkuId(self, skuname): > if not self.__SkuInherit: >-- >2.6.1.windows.1 > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel