public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTools: Add *B Flag for the field that from command line
Date: Fri, 23 Feb 2018 09:44:17 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1CEE8E@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1519362421-27388-1-git-send-email-yonghong.zhu@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Yonghong Zhu
>Sent: Friday, February 23, 2018 1:07 PM
>To: edk2-devel@lists.01.org
>Subject: [edk2] [Patch] BaseTools: Add *B Flag for the field that from
>command line
>
>For structure PCD, the field value may override in the command line,
>so in the report when we print the field info we add *B Flag for those
>field.
>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
>---
> BaseTools/Source/Python/build/BuildReport.py | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
>diff --git a/BaseTools/Source/Python/build/BuildReport.py
>b/BaseTools/Source/Python/build/BuildReport.py
>index 53d0039..2114499 100644
>--- a/BaseTools/Source/Python/build/BuildReport.py
>+++ b/BaseTools/Source/Python/build/BuildReport.py
>@@ -1234,18 +1234,14 @@ class PcdReport(object):
>                     self.PrintPcdDefault(File, Pcd, IsStructure, DscMatch,
>DscDefaultValue, InfMatch, InfDefaultValue, DecMatch, DecDefaultValue)
>
>     def PrintStructureInfo(self, File, Struct):
>         NewInfo = collections.OrderedDict()
>         for Key, Value in Struct.items():
>-            if Key not in NewInfo:
>-                NewInfo[Key] = Value[0]
>+            if Value[1] and 'build command options' in Value[1]:
>+                FileWrite(File, '    *B  %-*s = %s' % (self.MaxLen + 4, '.' + Key,
>Value[0]))
>             else:
>-                del NewInfo[Key]
>-                NewInfo[Key] = Value[0]
>-        if NewInfo:
>-            for item in NewInfo:
>-                FileWrite(File, '        %-*s = %s' % (self.MaxLen + 4, '.' + item,
>NewInfo[item]))
>+                FileWrite(File, '        %-*s = %s' % (self.MaxLen + 4, '.' + Key, Value[0]))
>
>     def StrtoHex(self, value):
>         try:
>             value = hex(int(value))
>             return value
>--
>2.6.1.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel


      reply	other threads:[~2018-02-23  9:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-23  5:07 [Patch] BaseTools: Add *B Flag for the field that from command line Yonghong Zhu
2018-02-23  9:44 ` Gao, Liming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E1CEE8E@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox