From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 801C02243693B for ; Fri, 23 Feb 2018 01:38:21 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Feb 2018 01:44:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,382,1515484800"; d="scan'208";a="33548788" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga001.jf.intel.com with ESMTP; 23 Feb 2018 01:44:22 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 23 Feb 2018 01:44:21 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.125]) by shsmsx102.ccr.corp.intel.com ([169.254.2.124]) with mapi id 14.03.0319.002; Fri, 23 Feb 2018 17:44:17 +0800 From: "Gao, Liming" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch] BaseTools: Add *B Flag for the field that from command line Thread-Index: AQHTrGQqdLdxNKJjnUiXugKnFi3UYqOxvPNw Date: Fri, 23 Feb 2018 09:44:17 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1CEE8E@SHSMSX104.ccr.corp.intel.com> References: <1519362421-27388-1-git-send-email-yonghong.zhu@intel.com> In-Reply-To: <1519362421-27388-1-git-send-email-yonghong.zhu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools: Add *B Flag for the field that from command line X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Feb 2018 09:38:21 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Friday, February 23, 2018 1:07 PM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch] BaseTools: Add *B Flag for the field that from >command line > >For structure PCD, the field value may override in the command line, >so in the report when we print the field info we add *B Flag for those >field. > >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Yonghong Zhu >--- > BaseTools/Source/Python/build/BuildReport.py | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > >diff --git a/BaseTools/Source/Python/build/BuildReport.py >b/BaseTools/Source/Python/build/BuildReport.py >index 53d0039..2114499 100644 >--- a/BaseTools/Source/Python/build/BuildReport.py >+++ b/BaseTools/Source/Python/build/BuildReport.py >@@ -1234,18 +1234,14 @@ class PcdReport(object): > self.PrintPcdDefault(File, Pcd, IsStructure, DscMatch= , >DscDefaultValue, InfMatch, InfDefaultValue, DecMatch, DecDefaultValue) > > def PrintStructureInfo(self, File, Struct): > NewInfo =3D collections.OrderedDict() > for Key, Value in Struct.items(): >- if Key not in NewInfo: >- NewInfo[Key] =3D Value[0] >+ if Value[1] and 'build command options' in Value[1]: >+ FileWrite(File, ' *B %-*s =3D %s' % (self.MaxLen + 4,= '.' + Key, >Value[0])) > else: >- del NewInfo[Key] >- NewInfo[Key] =3D Value[0] >- if NewInfo: >- for item in NewInfo: >- FileWrite(File, ' %-*s =3D %s' % (self.MaxLen + 4,= '.' + item, >NewInfo[item])) >+ FileWrite(File, ' %-*s =3D %s' % (self.MaxLen + 4,= '.' + Key, Value[0])) > > def StrtoHex(self, value): > try: > value =3D hex(int(value)) > return value >-- >2.6.1.windows.1 > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel