From: "Gao, Liming" <liming.gao@intel.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTools:Override the MAKE_FLAGS by BuildOptions in DSC
Date: Tue, 27 Feb 2018 06:54:28 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1D3E41@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1519480462-16108-1-git-send-email-yonghong.zhu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Yonghong Zhu
> Sent: Saturday, February 24, 2018 9:54 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [Patch] BaseTools:Override the MAKE_FLAGS by BuildOptions in DSC
>
> The issue that *_*_*_MAKE_FLAGS doesn't work in DSC [BuildOptions]
> section. It means MAKE flags can't be set in platform DSC file.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
> ---
> BaseTools/Source/Python/AutoGen/AutoGen.py | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py b/BaseTools/Source/Python/AutoGen/AutoGen.py
> index 405bfa1..1787dec 100644
> --- a/BaseTools/Source/Python/AutoGen/AutoGen.py
> +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py
> @@ -1905,10 +1905,17 @@ class PlatformAutoGen(AutoGen):
> self._BuildCommand += SplitOption(self.ToolDefinition["MAKE"]["PATH"])
> if "FLAGS" in self.ToolDefinition["MAKE"]:
> NewOption = self.ToolDefinition["MAKE"]["FLAGS"].strip()
> if NewOption != '':
> self._BuildCommand += SplitOption(NewOption)
> + if "MAKE" in self.EdkIIBuildOption:
> + if "FLAGS" in self.EdkIIBuildOption["MAKE"]:
> + Flags = self.EdkIIBuildOption["MAKE"]["FLAGS"]
> + if Flags.startswith('='):
> + self._BuildCommand = [self._BuildCommand[0]] + [Flags[1:]]
> + else:
> + self._BuildCommand += [Flags]
> return self._BuildCommand
>
> ## Get tool chain definition
> #
> # Get each tool defition for given tool chain from tools_def.txt and platform
> --
> 2.6.1.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2018-02-27 6:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-24 13:54 [Patch] BaseTools:Override the MAKE_FLAGS by BuildOptions in DSC Yonghong Zhu
2018-02-27 6:54 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E1D3E41@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox