From: "Gao, Liming" <liming.gao@intel.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTools: Enhance FV info report file path to support absolute path
Date: Wed, 28 Feb 2018 05:27:06 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1D4A10@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1519787434-10352-1-git-send-email-yonghong.zhu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Yonghong Zhu
>Sent: Wednesday, February 28, 2018 11:11 AM
>To: edk2-devel@lists.01.org
>Subject: [edk2] [Patch] BaseTools: Enhance FV info report file path to support
>absolute path
>
>When generate build report, Tool will get the info like size, Fv Name,
>etc from the xx.Fv.txt file and add these info into the build report.
>This patch support the xx.Fv.txt to use absolute file path format since
>user may provide specified FV path.
>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
>---
> BaseTools/Source/Python/build/BuildReport.py | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
>diff --git a/BaseTools/Source/Python/build/BuildReport.py
>b/BaseTools/Source/Python/build/BuildReport.py
>index 58595d6..b2cc6ee 100644
>--- a/BaseTools/Source/Python/build/BuildReport.py
>+++ b/BaseTools/Source/Python/build/BuildReport.py
>@@ -1724,11 +1724,17 @@ class FdRegionReport(object):
>
> if self.Type == "FV":
> FvTotalSize = 0
> FvTakenSize = 0
> FvFreeSize = 0
>- FvReportFileName = os.path.join(self._FvDir, FvName + ".Fv.txt")
>+ if not os.path.isfile(FvName):
>+ FvReportFileName = os.path.join(self._FvDir, FvName + ".Fv.txt")
>+ else:
>+ if FvName.upper().endswith('.FV'):
>+ FvReportFileName = FvName + ".txt"
>+ else:
>+ FvReportFileName = FvName + ".Fv.txt"
> try:
> #
> # Collect size info in the firmware volume.
> #
> FvReport = open(FvReportFileName).read()
>--
>2.6.1.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2018-02-28 5:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 3:10 [Patch] BaseTools: Enhance FV info report file path to support absolute path Yonghong Zhu
2018-02-28 5:27 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E1D4A10@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox