From: "Gao, Liming" <liming.gao@intel.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTools: Fix the bug for single module build with GenC/GenMake
Date: Thu, 1 Mar 2018 04:09:06 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1D551D@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1519834115-2204-1-git-send-email-yonghong.zhu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Yonghong Zhu
>Sent: Thursday, March 01, 2018 12:09 AM
>To: edk2-devel@lists.01.org
>Subject: [edk2] [Patch] BaseTools: Fix the bug for single module build with
>GenC/GenMake
>
>copy the same logic from _BuildPa() function.
>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
>---
> BaseTools/Source/Python/build/build.py | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
>diff --git a/BaseTools/Source/Python/build/build.py
>b/BaseTools/Source/Python/build/build.py
>index 14a2ceb..bb130a0 100644
>--- a/BaseTools/Source/Python/build/build.py
>+++ b/BaseTools/Source/Python/build/build.py
>@@ -1863,17 +1863,25 @@ class Build():
> continue
> # Not to auto-gen for targets 'clean', 'cleanlib', 'cleanall', 'run',
>'fds'
> if self.Target not in ['clean', 'cleanlib', 'cleanall', 'run', 'fds']:
> # for target which must generate AutoGen code and makefile
> if not self.SkipAutoGen or self.Target == 'genc':
>+ self.Progress.Start("Generating code")
> Ma.CreateCodeFile(True)
>+ self.Progress.Stop("done!")
>+ if self.Target == "genc":
>+ return True
> if not self.SkipAutoGen or self.Target == 'genmake':
>+ self.Progress.Start("Generating makefile")
> if CmdListDict and self.Fdf and (Module.File, Arch) in
>CmdListDict:
> Ma.CreateMakeFile(True, CmdListDict[Module.File, Arch])
> del CmdListDict[Module.File, Arch]
> else:
> Ma.CreateMakeFile(True)
>+ self.Progress.Stop("done!")
>+ if self.Target == "genmake":
>+ return True
> self.BuildModules.append(Ma)
> self.AutoGenTime += int(round((time.time() - AutoGenStart)))
> MakeStart = time.time()
> for Ma in self.BuildModules:
> if not Ma.IsBinaryModule:
>--
>2.6.1.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2018-03-01 4:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 16:08 [Patch] BaseTools: Fix the bug for single module build with GenC/GenMake Yonghong Zhu
2018-03-01 4:09 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E1D551D@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox