From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 72B49223522AF for ; Wed, 28 Feb 2018 20:03:02 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Feb 2018 20:09:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,407,1515484800"; d="scan'208";a="35005510" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga001.jf.intel.com with ESMTP; 28 Feb 2018 20:09:10 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 28 Feb 2018 20:09:09 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.125]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.116]) with mapi id 14.03.0319.002; Thu, 1 Mar 2018 12:09:07 +0800 From: "Gao, Liming" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch] BaseTools: Fix the bug for single module build with GenC/GenMake Thread-Index: AQHTsK5v+ZSyuxxZe0Cs2GAHTVDjA6O6xLVQ Date: Thu, 1 Mar 2018 04:09:06 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1D551D@SHSMSX104.ccr.corp.intel.com> References: <1519834115-2204-1-git-send-email-yonghong.zhu@intel.com> In-Reply-To: <1519834115-2204-1-git-send-email-yonghong.zhu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools: Fix the bug for single module build with GenC/GenMake X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Mar 2018 04:03:02 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Thursday, March 01, 2018 12:09 AM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch] BaseTools: Fix the bug for single module build wit= h >GenC/GenMake > >copy the same logic from _BuildPa() function. > >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Yonghong Zhu >--- > BaseTools/Source/Python/build/build.py | 8 ++++++++ > 1 file changed, 8 insertions(+) > >diff --git a/BaseTools/Source/Python/build/build.py >b/BaseTools/Source/Python/build/build.py >index 14a2ceb..bb130a0 100644 >--- a/BaseTools/Source/Python/build/build.py >+++ b/BaseTools/Source/Python/build/build.py >@@ -1863,17 +1863,25 @@ class Build(): > continue > # Not to auto-gen for targets 'clean', 'clean= lib', 'cleanall', 'run', >'fds' > if self.Target not in ['clean', 'cleanlib', '= cleanall', 'run', 'fds']: > # for target which must generate AutoGen = code and makefile > if not self.SkipAutoGen or self.Target = =3D=3D 'genc': >+ self.Progress.Start("Generating code"= ) > Ma.CreateCodeFile(True) >+ self.Progress.Stop("done!") >+ if self.Target =3D=3D "genc": >+ return True > if not self.SkipAutoGen or self.Target = =3D=3D 'genmake': >+ self.Progress.Start("Generating makef= ile") > if CmdListDict and self.Fdf and (Modu= le.File, Arch) in >CmdListDict: > Ma.CreateMakeFile(True, CmdListDi= ct[Module.File, Arch]) > del CmdListDict[Module.File, Arch= ] > else: > Ma.CreateMakeFile(True) >+ self.Progress.Stop("done!") >+ if self.Target =3D=3D "genmake": >+ return True > self.BuildModules.append(Ma) > self.AutoGenTime +=3D int(round((time.time() - AutoGe= nStart))) > MakeStart =3D time.time() > for Ma in self.BuildModules: > if not Ma.IsBinaryModule: >-- >2.6.1.windows.1 > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel