From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B1E2822485A66 for ; Fri, 2 Mar 2018 05:47:12 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Mar 2018 05:53:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,412,1515484800"; d="scan'208";a="34977741" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga001.fm.intel.com with ESMTP; 02 Mar 2018 05:53:22 -0800 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 2 Mar 2018 05:53:21 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 2 Mar 2018 05:53:21 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.125]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.130]) with mapi id 14.03.0319.002; Fri, 2 Mar 2018 21:53:20 +0800 From: "Gao, Liming" To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH 1/2] MdePkg/DevicePathFromText: Fix bug when converting iSCSI node Thread-Index: AQHTshzucp3gqpB6EkeyaJU5WKz8S6O892Vg Date: Fri, 2 Mar 2018 13:53:19 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1D671F@SHSMSX104.ccr.corp.intel.com> References: <20180302115206.143528-1-ruiyu.ni@intel.com> <20180302115206.143528-2-ruiyu.ni@intel.com> In-Reply-To: <20180302115206.143528-2-ruiyu.ni@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 1/2] MdePkg/DevicePathFromText: Fix bug when converting iSCSI node X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Mar 2018 13:47:13 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ru= iyu Ni > Sent: Friday, March 2, 2018 7:52 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH 1/2] MdePkg/DevicePathFromText: Fix bug when conve= rting iSCSI node >=20 > If protocol string is not specified, default TCP(0) should be used. > Today's implementation wrongly sets to 1 for this case. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu Ni > Cc: Yonghong Zhu > --- > MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c b/MdeP= kg/Library/UefiDevicePathLib/DevicePathFromText.c > index 0459f0ab25..c66b77ba6c 100644 > --- a/MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c > +++ b/MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c > @@ -1,7 +1,7 @@ > /** @file > DevicePathFromText protocol as defined in the UEFI 2.0 specification. >=20 > -Copyright (c) 2013 - 2017, Intel Corporation. All rights reserved.
> +Copyright (c) 2013 - 2018, Intel Corporation. All rights reserved.
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the BS= D License > which accompanies this distribution. The full text of the license may b= e found at > @@ -2581,7 +2581,7 @@ DevPathFromTextiSCSI ( >=20 > ISCSIDevPath->LoginOption =3D (UINT16) Options; >=20 > - if (StrCmp (ProtocolStr, L"TCP") =3D=3D 0) { > + if (IS_NULL (*ProtocolStr) || (StrCmp (ProtocolStr, L"TCP") =3D=3D 0))= { > ISCSIDevPath->NetworkProtocol =3D 0; > } else { > // > -- > 2.16.1.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel