From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AA69221E082B6 for ; Fri, 2 Mar 2018 21:14:36 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Mar 2018 21:20:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,415,1515484800"; d="scan'208";a="35577850" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga001.jf.intel.com with ESMTP; 02 Mar 2018 21:20:46 -0800 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 2 Mar 2018 21:20:46 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 2 Mar 2018 21:20:45 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.125]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.116]) with mapi id 14.03.0319.002; Sat, 3 Mar 2018 13:20:44 +0800 From: "Gao, Liming" To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" CC: "Lin, Jie" , "Zhu, Yonghong" Thread-Topic: [PATCH v2] MdePkg/DevicePathFromText: Fix byte orders of iSCSI.Lun Thread-Index: AQHTsq38QGk3NdxkFEWYnFlKOnc7kaO9+WAA Date: Sat, 3 Mar 2018 05:20:43 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1D6BA0@SHSMSX104.ccr.corp.intel.com> References: <20180303051039.158176-1-ruiyu.ni@intel.com> In-Reply-To: <20180303051039.158176-1-ruiyu.ni@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2] MdePkg/DevicePathFromText: Fix byte orders of iSCSI.Lun X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Mar 2018 05:14:37 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Ni, Ruiyu > Sent: Saturday, March 3, 2018 1:11 PM > To: edk2-devel@lists.01.org > Cc: Lin, Jie ; Gao, Liming ; Zhu= , Yonghong > Subject: [PATCH v2] MdePkg/DevicePathFromText: Fix byte orders of iSCSI.L= un >=20 > Per UEFI spec, iSCSI.Lun is a 8-byte array with byte #0 in the left. > It means "0102030405060708" should be converted to: > UINT8[8] =3D {01, 02, 03, 04, 05, 06, 07, 08} > or UINT64 =3D {0807060504030201} >=20 > Today's implementation wrongly uses the reversed order. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu Ni > Cc: Jie Lin > Cc: Liming Gao > Cc: Yonghong Zhu > --- > MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c b/MdeP= kg/Library/UefiDevicePathLib/DevicePathFromText.c > index c66b77ba6c..35a73e83ff 100644 > --- a/MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c > +++ b/MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c > @@ -2542,6 +2542,7 @@ DevPathFromTextiSCSI ( > CHAR16 *ProtocolStr; > CHAR8 *AsciiStr; > ISCSI_DEVICE_PATH_WITH_NAME *ISCSIDevPath; > + UINT64 Lun; >=20 > NameStr =3D GetNextParamStr (&TextDeviceNode); > PortalGroupStr =3D GetNextParamStr (&TextDeviceNode); > @@ -2560,7 +2561,8 @@ DevPathFromTextiSCSI ( > StrToAscii (NameStr, &AsciiStr); >=20 > ISCSIDevPath->TargetPortalGroupTag =3D (UINT16) Strtoi (PortalGroupStr= ); > - Strtoi64 (LunStr, &ISCSIDevPath->Lun); > + Strtoi64 (LunStr, &Lun); > + WriteUnaligned64 ((UINT64 *) &ISCSIDevPath->Lun, SwapBytes64 (Lun)); >=20 > Options =3D 0x0000; > if (StrCmp (HeaderDigestStr, L"CRC32C") =3D=3D 0) { > -- > 2.16.1.windows.1