From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 56E9C21E082B6 for ; Fri, 2 Mar 2018 23:31:56 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Mar 2018 23:38:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,416,1515484800"; d="scan'208";a="31117244" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by FMSMGA003.fm.intel.com with ESMTP; 02 Mar 2018 23:38:06 -0800 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 2 Mar 2018 23:38:06 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 2 Mar 2018 23:38:05 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.125]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.116]) with mapi id 14.03.0319.002; Sat, 3 Mar 2018 15:38:04 +0800 From: "Gao, Liming" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch 1/2] BaseTools: Fix bug when converting iSCSI node Thread-Index: AQHTssJBnAoxOvTtVEq1bqvY7I5f+qO+H3Jg Date: Sat, 3 Mar 2018 07:38:03 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1D6C8A@SHSMSX104.ccr.corp.intel.com> References: <1520062536-14244-1-git-send-email-yonghong.zhu@intel.com> In-Reply-To: <1520062536-14244-1-git-send-email-yonghong.zhu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch 1/2] BaseTools: Fix bug when converting iSCSI node X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Mar 2018 07:31:56 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao Please update commit message with MdePkg Fix hash value. > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Yo= nghong Zhu > Sent: Saturday, March 3, 2018 3:36 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch 1/2] BaseTools: Fix bug when converting iSCSI node >=20 > If protocol string is not specified, default TCP(0) should be used. > Today's implementation wrongly sets to 1 for this case. > Copy the fix solution from MdePkg. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Yonghong Zhu > --- > BaseTools/Source/C/DevicePath/DevicePathFromText.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/BaseTools/Source/C/DevicePath/DevicePathFromText.c b/BaseToo= ls/Source/C/DevicePath/DevicePathFromText.c > index 776cf05..06482ae 100644 > --- a/BaseTools/Source/C/DevicePath/DevicePathFromText.c > +++ b/BaseTools/Source/C/DevicePath/DevicePathFromText.c > @@ -2424,11 +2424,11 @@ DevPathFromTextiSCSI ( > Options |=3D 0x1000; > } >=20 > ISCSIDevPath->LoginOption =3D (UINT16) Options; >=20 > - if (StrCmp (ProtocolStr, L"TCP") =3D=3D 0) { > + if (IS_NULL (*ProtocolStr) || (StrCmp (ProtocolStr, L"TCP") =3D=3D 0))= { > ISCSIDevPath->NetworkProtocol =3D 0; > } else { > // > // Undefined and reserved. > // > -- > 2.6.1.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel