From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9E25F21F6A6D0 for ; Sun, 4 Mar 2018 22:07:11 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Mar 2018 22:13:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,426,1515484800"; d="scan'208";a="22562765" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga008.jf.intel.com with ESMTP; 04 Mar 2018 22:13:23 -0800 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 4 Mar 2018 22:13:23 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 4 Mar 2018 22:13:23 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.125]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.116]) with mapi id 14.03.0319.002; Mon, 5 Mar 2018 14:13:20 +0800 From: "Gao, Liming" To: "Feng, Bob C" , "edk2-devel@lists.01.org" Thread-Topic: [Patch] BaseTools: Support H"{}" format for Sructure Pcd. Thread-Index: AQHTtEi4K+gvEWTBok6Uu8GTDV6va6PBKYgg Date: Mon, 5 Mar 2018 06:13:19 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1D7437@SHSMSX104.ccr.corp.intel.com> References: <20180305061047.18128-1-bob.c.feng@intel.com> In-Reply-To: <20180305061047.18128-1-bob.c.feng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools: Support H"{}" format for Sructure Pcd. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Mar 2018 06:07:12 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: Feng, Bob C >Sent: Monday, March 05, 2018 2:11 PM >To: edk2-devel@lists.01.org >Cc: Feng, Bob C ; Gao, Liming >Subject: [Patch] BaseTools: Support H"{}" format for Sructure Pcd. > >Support H"{}" format for Sructure Pcd from CommandLine > >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Bob Feng >Cc: Liming Gao >--- > BaseTools/Source/Python/Workspace/DscBuildData.py | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py >b/BaseTools/Source/Python/Workspace/DscBuildData.py >index 9d787702c2..edf90dbd59 100644 >--- a/BaseTools/Source/Python/Workspace/DscBuildData.py >+++ b/BaseTools/Source/Python/Workspace/DscBuildData.py >@@ -911,11 +911,10 @@ class DscBuildData(PlatformBuildClassObject): > if not ValueStr[1]: > EdkLogger.error("build", FORMAT_INVALID, 'For Void* type = PCD, >when specify the Value in the command line, please use the following forma= t: >"string", L"string", H"{...}"') > ValueStr =3D ValueStr[0] + '"' + ValueStr[1:] + '"' > PredictedFieldType =3D "VOID*" > elif ValueStr.startswith('H') or ValueStr.startswith('{'): >- EdkLogger.error("build", FORMAT_INVALID, 'Currently we do not >support assign H"{...}" format for Pcd field.', ExtraData=3D"%s.%s.%s from >command line" % (TokenSpaceGuidCName, TokenCName, FieldName)) > ValueStr =3D ValueStr[1:] > PredictedFieldType =3D "VOID*" > elif ValueStr.upper() in ['TRUE', '0X1', '0X01', '1', 'FALSE', '0= X0', '0X00', '0']: > PredictedFieldType =3D "BOOLEAN" > elif ValueStr.isdigit() or ValueStr.upper().startswith('0X'): >-- >2.14.3.windows.1