From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BA1E322135D51 for ; Wed, 7 Mar 2018 00:51:14 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Mar 2018 00:57:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,435,1515484800"; d="scan'208";a="23603999" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga006.jf.intel.com with ESMTP; 07 Mar 2018 00:57:29 -0800 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 7 Mar 2018 00:57:28 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 7 Mar 2018 00:57:28 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.125]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.116]) with mapi id 14.03.0319.002; Wed, 7 Mar 2018 16:57:23 +0800 From: "Gao, Liming" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , "Shaw, Kevin W" Thread-Topic: [Patch V2] Build spec: update PCD value and SKU, DefaultStore info in report Thread-Index: AQHTrGYfFGjye5Brj0S4W64aHSot0KPEi75g Date: Wed, 7 Mar 2018 08:57:23 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1D8B2D@SHSMSX104.ccr.corp.intel.com> References: <1519363265-25228-1-git-send-email-yonghong.zhu@intel.com> In-Reply-To: <1519363265-25228-1-git-send-email-yonghong.zhu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch V2] Build spec: update PCD value and SKU, DefaultStore info in report X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2018 08:51:15 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: Zhu, Yonghong >Sent: Friday, February 23, 2018 1:21 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming ; Kinney, Michael D >; Shaw, Kevin W >Subject: [Patch V2] Build spec: update PCD value and SKU, DefaultStore inf= o in >report > >V2: Add *B info for structure pcd field value that from build command > >Cc: Liming Gao >Cc: Michael Kinney >Cc: Kevin W Shaw >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Yonghong Zhu >--- > 13_build_reports/134_platform_summary.md | 10 ++++-- > 13_build_reports/136_global_pcd_section.md | 49 >++++++++++++++++++++++++++++-- > 13_build_reports/138_module_section.md | 9 +++++- > 3 files changed, 63 insertions(+), 5 deletions(-) > >diff --git a/13_build_reports/134_platform_summary.md >b/13_build_reports/134_platform_summary.md >index 083d714..09b8db6 100644 >--- a/13_build_reports/134_platform_summary.md >+++ b/13_build_reports/134_platform_summary.md >@@ -37,11 +37,13 @@ following items: > * Platform Name : %Platform UI name: '`PLATFORM_NAME`' in DSC >`[Defines]` > section% > * Platform DSC Path: %Path of platform DSC file% > * Architectures : %List string of all architectures used in build% > * Tool Chain : %Tool chain string% >-* Target : %Target String" >+* Target : %Target String% >+* SKUID: %Platform SKUID String% >+* DefaultStore: %Platform DefaultStore String% > * Output Path : %Path to platform build directory% > * Build Environment : %Environment string reported by Python% > * Build Duration : %Build duration time string% > * AutoGen Duration : %AutoGen duration time string if it exists% > * Make Duration : %Make duration time string if it exists% >@@ -54,10 +56,12 @@ following items: > Platform Name: NT32 > Platform DSC Path: s:\edk2\Nt32Pkg\Nt32Pkg.dsc > Architectures: IA32 > Tool Chain: VS2008x86 > Target: DEBUG >+SKUID: DEFAULT >+DefaultStore: STANDARD > Output Path: s:\edk2\Build\NT32IA32 > Build Environment: Windows-7-6.1.7601-SP1 > Build Duration: 00:01:29 > AutoGen Duration: 00:00:10 > Make Duration: 00:01:02 >@@ -104,10 +108,11 @@ The first line is required: > `[*P|*F|*B] : () =3D ` > > * `*P` means the Pcd's value was obtained from the DSC file > * `*F` means the PCD's value was obtained from the FDF file. > * `*B` means the PCD's value set by a build option. >+**Note:** If the Pcd is a Structure PCD, is the Struct Name. > > Additional lines may be displayed showing default values when the value i= s >not a > default value. > > ### Example >@@ -135,15 +140,16 @@ not used PCD section is generated. > PCD values derived from expressions or other PCDs are not differentiated = in >the > report. Only the final value is displayed. > > The first line is required: > >-`[*P|*F|*B] : () =3D ` >+`[*P|*F|*B] : () >[()][()] =3D ` > > * `*P` means the Pcd's value was obtained from the DSC file > * `*F` means the PCD's value was obtained from the FDF file. > * `*B` means the PCD's value set by a build option. >+**Note:** If the Pcd is a Structure PCD, is the Struct Name. > > Additional lines may be displayed showing default values when the value i= s >not a > default value. > > Since the PCDs in this section are not used by any module, the PCD value = is >not >diff --git a/13_build_reports/136_global_pcd_section.md >b/13_build_reports/136_global_pcd_section.md >index d768488..c300920 100644 >--- a/13_build_reports/136_global_pcd_section.md >+++ b/13_build_reports/136_global_pcd_section.md >@@ -52,18 +52,19 @@ Each global PCD item contains one or more lines: > > ### 13.6.1 Required line > > The first line is required: > >-`[*P|*F|*B] : () =3D ` >+`[*P|*F|*B] : () >[()][()] =3D ` > >-* `*P` means the Pcd's value was obtained from the DSC file >+* `*P` means the PCD's value was obtained from the DSC file > * `*F` means the PCD's value was obtained from the FDF file. > * `*B` means the PCD's value was obtained from a build option. > * If no `*P`, `*F` or `*B` is shown, the PCD's value comes from DEC file.= If the > value obtained from either a build option, the DSC or FDF is the same a= s the > value in the DEC, then `*B`, `*P` or `*F` will not be shown in the repo= rt. >+**Note:** If the Pcd is a Structure PCD, is the Struct Name. > > #### Examples > > ``` > *P PcdWinNtFirmwareVolume : FIXED (VOID*) =3D L"..\\Fv\\N= t32.fd" >@@ -71,10 +72,14 @@ The first line is required: > DEC DEFAULT =3D 0x0 > > gTokenSpaceGuid > *B LogEnable : FIXED (UNIT32) =3D 0x1 > DEC DEFAULT =3D 0x0 >+*P TestDynamic : DYN (VOID*) (DEFAULT) =3D L= "COM1!COM2" >+ : DYN (VOID*) (SKU1) =3D L= "COM3!COM4" >+ : DYN (VOID*) (SKU2) =3D L= "COM5!COM6" >+ DEC DEFAULT =3D L"COM1!= COM0" > ``` > > ### 13.6.2 Optional lines > > #### 13.6.2.1 Dynamic/DynamicEx >@@ -139,5 +144,45 @@ These lines are formatted as: > > ********** > **Note:** Global PCD section is present when **PCD** is specified in **- >Y** > option. > ********** >+ >+#### 13.6.2.4 Field value for Structure PCD >+If the Pcd is a Structure Pcd, every field value that user specified in D= SC/DEC >+file and build command will print out. The field value is from DSC/DEC fi= le or >+build command, not from the final structure byte array, and the field ord= er is >+same as it in DSC/DEC file. when the field value is from build command, t= ool >will >+additional print a *B Flag. >+ >+#### Example >+ >+``` >+gEfiMdePkgTokenSpaceGuid >+*P TestFix : FIXED (TEST) =3D { >+ >0xff,0x02,0x00,0x2e,0xf6,0x08,0x6f,0x19,0x5c,0x8e,0x49,0x91,0x57,0x00,0x00= , >0x00, >+ 0x00,0x64,0x00,0x00,0x00} >+ .A =3D 0x2 >+ .C =3D 0x0 >+ .Array =3D {0x2e,0xf6,0x08,0x6f,0x19,0x5c,0x8e,0x49,0x= 91,0x57} >+ .D =3D 0x64 >+ DEC DEFAULT =3D {0xFF,0xFF} >+ .A =3D 0xF >+ .C =3D 0xF >+*B TestDynamicExHii : DEXHII (TEST) (SKU1) (STANDARD) = =3D { >+ >0xff,0x01,0x00,0x2e,0xf6,0x08,0x6f,0x19,0x5c,0x8e,0x49,0x91,0x57,0x00,0x00= , >0x00, >+ 0x00,0x64,0x00,0x00,0x00} >+ .A =3D 0x1 >+ *B .C =3D 0x0 >+ .Array =3D {0x2e,0xf6,0x08,0x6f,0x19,0x5c,0x8e,0x49,0x= 91,0x57} >+ .D =3D 0x64 >+ : DEXHII (TEST) (SKU1) (Manufacturin= g) =3D { >+ >0xff,0x02,0x00,0x2e,0xf6,0x08,0x6f,0x20,0x5c,0x8e,0x49,0x91,0x57,0x00,0x00= , >0x00, >+ 0x00,0x68,0x00,0x00,0x00} >+ .A =3D 0x2 >+ *B .C =3D 0x0 >+ .Array =3D {0x2e,0xf6,0x08,0x6f,0x20,0x5c,0x8e,0x49,0x= 91,0x57} >+ .D =3D 0x68 >+ DEC DEFAULT =3D {0xFF,0xFF} >+ .A =3D 0xF >+ .C =3D 0xF >+``` >diff --git a/13_build_reports/138_module_section.md >b/13_build_reports/138_module_section.md >index 455537b..fb2417d 100644 >--- a/13_build_reports/138_module_section.md >+++ b/13_build_reports/138_module_section.md >@@ -238,11 +238,12 @@ gEfiMdeModulePkgTokenSpaceGuid > ``` > > Each PCD may contain up to four lines: > > 1. The first line is a mandatory line with the following format: >- `[*P|*M|*F| ] : () =3D ` >+ `[*P|*F|*B] : () >[()][()] =3D ` >+ **Note:** If the Pcd is a Structure PCD, is the Struct Nam= e. > - \*P means the Pcd's value is the platform default (listed in DSC PCD >common > section or inherited from Module INF file). > - \*M means the PCD's value in module INF was obtained from the >`[Components]` > section of the DSC file. > - \*F means the PCD's value is override in FDF file. >@@ -287,10 +288,16 @@ Each PCD may contain up to four lines: > *M PcdDebugPrintErrorLevel : FIXED (UINT32) =3D 0x80000042 > DSC DEFAULT =3D 0x80000040 > DEC DEFAULT =3D 0x80000000 > ``` > >+4. Additional lines may exist if the PCD is Structure PCD. Every field va= lue >+that user specified in DSC/DEC file and build command will print out. The= field >+value is from DSC/DEC file or build command, not from the final structure >byte >+array, and the field order is same as it in DSC/DEC file. when the field = value is >+from build command, tool will additional print a *B Flag. >+ > ********** > **Note:** This sub-section is present when **PCD** is specified in **-Y** > option. > ********** > >-- >2.6.1.windows.1