From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0D6A721E74935 for ; Wed, 7 Mar 2018 03:45:27 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Mar 2018 03:51:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,435,1515484800"; d="scan'208";a="25938531" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga002.fm.intel.com with ESMTP; 07 Mar 2018 03:51:42 -0800 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 7 Mar 2018 03:51:42 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 7 Mar 2018 03:51:40 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.125]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.253]) with mapi id 14.03.0319.002; Wed, 7 Mar 2018 19:51:39 +0800 From: "Gao, Liming" To: Laszlo Ersek , edk2-devel-01 Thread-Topic: [PATCH] BaseTools/header.makefile: revert gcc-8 "-Wno-xxx" options on OSX Thread-Index: AQHTtfdWoX1uNzlNIkS3GomSed5BuaPEqVog Date: Wed, 7 Mar 2018 11:51:39 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1D8C04@SHSMSX104.ccr.corp.intel.com> References: <20180307093259.7682-1-lersek@redhat.com> In-Reply-To: <20180307093259.7682-1-lersek@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] BaseTools/header.makefile: revert gcc-8 "-Wno-xxx" options on OSX X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2018 11:45:28 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Laszlo Ersek [mailto:lersek@redhat.com] > Sent: Wednesday, March 7, 2018 5:33 PM > To: edk2-devel-01 > Cc: Gao, Liming ; Zhu, Yonghong > Subject: [PATCH] BaseTools/header.makefile: revert gcc-8 "-Wno-xxx" optio= ns on OSX >=20 > I recently added the gcc-8 specific "-Wno-stringop-truncation" and > "-Wno-restrict" options to BUILD_CFLAGS, both for "Darwin" (XCODE5 / > clang, OSX) and otherwise (gcc, Linux / Cygwin). >=20 > I also regression-tested the change with gcc-4.8 on Linux -- gcc-4.8 does > not know either of the (gcc-8 specific) "-Wno-stringop-truncation" and > "-Wno-restrict" options, yet the build completed fine (by GCC design). >=20 > Regarding OSX, my expectation was that >=20 > - XCODE5 / clang would either recognize these warnings options (because > clang does recognize most -W options of gcc), >=20 > - or, similarly to gcc, clang would simply ignore the "-Wno-xxx" flags > that it didn't recognize. >=20 > Neither is the case; the new flags have broken the BaseTools build on OSX= . > Revert them (for OSX only). >=20 > Cc: Liming Gao > Cc: Yonghong Zhu > Reported-by: Liming Gao > Fixes: 1d212a83df0eaf32a6f5d4159beb2d77832e0231 > Fixes: 9222154ae7b3eef75ae88cdb56158256227cb929 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Laszlo Ersek > --- > BaseTools/Source/C/Makefiles/header.makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/BaseTools/Source/C/Makefiles/header.makefile b/BaseTools/Sou= rce/C/Makefiles/header.makefile > index 065a998bf5de..db436773cf40 100644 > --- a/BaseTools/Source/C/Makefiles/header.makefile > +++ b/BaseTools/Source/C/Makefiles/header.makefile > @@ -71,7 +71,7 @@ INCLUDE =3D $(TOOL_INCLUDE) -I $(MAKEROOT) -I $(MAKEROO= T)/Include/Common -I $(MAKE > BUILD_CPPFLAGS =3D $(INCLUDE) -O2 > ifeq ($(DARWIN),Darwin) > # assume clang or clang compatible flags on OS X > -BUILD_CFLAGS =3D -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror -W= no-deprecated-declarations -Wno-stringop-truncation > -Wno-restrict -Wno-self-assign -Wno-unused-result -nostdlib -c -g > +BUILD_CFLAGS =3D -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror -W= no-deprecated-declarations -Wno-self-assign > -Wno-unused-result -nostdlib -c -g > else > BUILD_CFLAGS =3D -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror -W= no-deprecated-declarations -Wno-stringop-truncation > -Wno-restrict -Wno-unused-result -nostdlib -c -g > endif > -- > 2.14.1.3.gb7cf6e02401b