* [Patch] BaseTools: Get Pcd DatumType from DEC file for --pcd
@ 2018-03-12 7:10 Yonghong Zhu
2018-03-12 7:36 ` Gao, Liming
0 siblings, 1 reply; 2+ messages in thread
From: Yonghong Zhu @ 2018-03-12 7:10 UTC (permalink / raw)
To: edk2-devel
It is regression bug that missing the Pcd DatumType info from DEC file
for --pcd .
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
---
BaseTools/Source/Python/Workspace/DscBuildData.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py b/BaseTools/Source/Python/Workspace/DscBuildData.py
index 91b3a27..9c43dac 100644
--- a/BaseTools/Source/Python/Workspace/DscBuildData.py
+++ b/BaseTools/Source/Python/Workspace/DscBuildData.py
@@ -964,10 +964,11 @@ class DscBuildData(PlatformBuildClassObject):
AUTOGEN_ERROR,
"The Pcd %s is found under multiple different TokenSpaceGuid: %s and %s." % (DisplayName, PcdItem.TokenSpaceGuidCName, TokenSpaceGuidCNameList[0])
)
else:
if (TokenCName, TokenSpaceGuidCName) in self.DecPcds:
+ PcdDatumType = self.DecPcds[(TokenCName, TokenSpaceGuidCName)].DatumType
FoundFlag = True
if not FoundFlag:
if HasTokenSpace:
EdkLogger.error('build', AUTOGEN_ERROR, "The Pcd %s.%s is not found in the DEC file." % (TokenSpaceGuidCName, DisplayName))
else:
--
2.6.1.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Patch] BaseTools: Get Pcd DatumType from DEC file for --pcd
2018-03-12 7:10 [Patch] BaseTools: Get Pcd DatumType from DEC file for --pcd Yonghong Zhu
@ 2018-03-12 7:36 ` Gao, Liming
0 siblings, 0 replies; 2+ messages in thread
From: Gao, Liming @ 2018-03-12 7:36 UTC (permalink / raw)
To: Zhu, Yonghong, edk2-devel@lists.01.org
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Yonghong Zhu
>Sent: Monday, March 12, 2018 3:11 PM
>To: edk2-devel@lists.01.org
>Subject: [edk2] [Patch] BaseTools: Get Pcd DatumType from DEC file for --pcd
>
>It is regression bug that missing the Pcd DatumType info from DEC file
>for --pcd .
>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
>---
> BaseTools/Source/Python/Workspace/DscBuildData.py | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py
>b/BaseTools/Source/Python/Workspace/DscBuildData.py
>index 91b3a27..9c43dac 100644
>--- a/BaseTools/Source/Python/Workspace/DscBuildData.py
>+++ b/BaseTools/Source/Python/Workspace/DscBuildData.py
>@@ -964,10 +964,11 @@ class DscBuildData(PlatformBuildClassObject):
> AUTOGEN_ERROR,
> "The Pcd %s is found under multiple different
>TokenSpaceGuid: %s and %s." % (DisplayName,
>PcdItem.TokenSpaceGuidCName, TokenSpaceGuidCNameList[0])
> )
> else:
> if (TokenCName, TokenSpaceGuidCName) in self.DecPcds:
>+ PcdDatumType = self.DecPcds[(TokenCName,
>TokenSpaceGuidCName)].DatumType
> FoundFlag = True
> if not FoundFlag:
> if HasTokenSpace:
> EdkLogger.error('build', AUTOGEN_ERROR, "The Pcd %s.%s is not
>found in the DEC file." % (TokenSpaceGuidCName, DisplayName))
> else:
>--
>2.6.1.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-12 7:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-12 7:10 [Patch] BaseTools: Get Pcd DatumType from DEC file for --pcd Yonghong Zhu
2018-03-12 7:36 ` Gao, Liming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox