public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: Arvind Prasanna <arvindprasanna@gmail.com>,
	"Zhu, Yonghong" <yonghong.zhu@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] edksetup.sh: Update help section regarding positional
Date: Mon, 12 Mar 2018 14:55:29 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1E5764@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <CAK-=9LqFN3c_ZOnFO=fAnnk6wqKxmbF+LXhek2x6tkXNB37e-g@mail.gmail.com>

Arvind:
  Could you give one example to explain this usage?

---------- Forwarded message ----------
From: Arvind Prasanna <arvindprasanna@gmail.com<mailto:arvindprasanna@gmail.com>>
Date: Sat, Mar 10, 2018 at 3:18 AM
Subject: [PATCH] edksetup.sh: Update help section regarding positional
To: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
Cc: Arvind Prasanna <arvindprasanna@gmail.com<mailto:arvindprasanna@gmail.com>>


It is possible to source edksetup.sh from another script. If the
calling/sourcing script has any positional parameters set, those are
incorrectly accounted for in edksetup.sh while sourcing it resulting in
the the help section always being shown. This patch updates the help
section advising the user about these set positional parameters so they
can be unset prior to sourcing edksetup.sh.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Arvind Prasanna <arvindprasanna@gmail.com<mailto:arvindprasanna@gmail.com>>
---
 edksetup.sh | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/edksetup.sh b/edksetup.sh
index 93d6525..a3d5560 100755
--- a/edksetup.sh
+++ b/edksetup.sh
@@ -42,6 +42,8 @@ function HelpMsg()
   echo Please note: This script must be \'sourced\' so the environment can be changed.
   echo ". $SCRIPTNAME"
   echo "source $SCRIPTNAME"
+  echo "If this script is being sourced from another script, please ensure that the"
+  echo "sourcing/calling script has no set postional parameters."
 }

 function SetWorkspace()
--
2.7.4


       reply	other threads:[~2018-03-12 14:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1520669933-8602-1-git-send-email-arvindprasanna@gmail.com>
     [not found] ` <CAK-=9LqFN3c_ZOnFO=fAnnk6wqKxmbF+LXhek2x6tkXNB37e-g@mail.gmail.com>
2018-03-12 14:55   ` Gao, Liming [this message]
2018-03-12 17:17     ` [PATCH] edksetup.sh: Update help section regarding positional Arvind Prasanna
2018-03-13  5:38       ` [PATCH v2] edksetup.sh: Update help section regarding positional parameters Arvind Prasanna
2018-03-13  5:44         ` Arvind Prasanna
2018-03-13 13:44           ` Gao, Liming
2018-03-13 16:09             ` Arvind Prasanna
2018-03-13  5:41       ` [PATCH] edksetup.sh: Update help section regarding positional Arvind Prasanna
2018-03-13 18:51       ` [PATCH v3] edksetup.sh: Update help section regarding positional parameters Arvind Prasanna
2018-03-10 16:11 [PATCH] edksetup.sh: Update help section regarding positional Arvind Prasanna
2018-03-14 11:25 ` Leif Lindholm
2018-03-16  6:18   ` Arvind Prasanna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E1E5764@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox