public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [RFC] Remove X86 .asm and .S assembly files in EDK2
Date: Thu, 15 Mar 2018 01:56:22 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1E6C13@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <E92EE9817A31E24EB0585FDF735412F5B8973654@ORSMSX113.amr.corp.intel.com>

Mike:
  Now, %pragma macho subsections_via_symbols can't be enabled. So, will nasm generate the bigger image size than .S assembly on macho? If yes, I agree nasm is not same to .S. .S may be kept for a while. But, .asm is not necessary. We can remove .asm first. 

Thanks
Liming
> -----Original Message-----
> From: Kinney, Michael D
> Sent: Wednesday, March 14, 2018 4:00 AM
> To: Gao, Liming <liming.gao@intel.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: RE: [RFC] Remove X86 .asm and .S assembly files in EDK2
> 
> Liming,
> 
> After further evaluation on use of NASM with macho
> there are a couple issues that need to be resolved
> before the .asm and .S files can be removed from
> all components.
> 
> The details are at:
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=881
> 
> NASM issues to be resolved are:
> 
> https://bugzilla.nasm.us/show_bug.cgi?id=3392469
> https://bugzilla.nasm.us/show_bug.cgi?id=3392470
> 
> The recommendation is to not switch to NASM only
> for libraries until the dead code stripping feature
> works as expected on macho.
> 
> We can consider moving to NASM only for NASM files
> in a module if there are no NASM functions that would
> be dead stripped.  The recommendation for these types
> of NASM files is do not use the following pragma
> until the NASM issues above are resolved.
> 
>   %pragma macho subsections_via_symbols
> 
> Best regards,
> 
> Mike
> 
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-
> > bounces@lists.01.org] On Behalf Of Gao, Liming
> > Sent: Wednesday, January 31, 2018 3:06 AM
> > To: edk2-devel@lists.01.org
> > Subject: [edk2] [RFC] Remove X86 .asm and .S assembly
> > files in EDK2
> >
> > Edk2 has used nasm assembly file for all tool chains.
> > So, IA32 and X64 .asm and .S assembly files can be
> > removed if their nasm files are ready. It can save the
> > maintain effort and avoid the confuse.
> >
> >
> >
> > If you have any comments on this change, please let me
> > know.
> >
> > Thanks
> > Liming
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel


  reply	other threads:[~2018-03-15  1:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-31 11:06 [RFC] Remove X86 .asm and .S assembly files in EDK2 Gao, Liming
2018-01-31 13:15 ` Laszlo Ersek
2018-03-13 20:00 ` Kinney, Michael D
2018-03-15  1:56   ` Gao, Liming [this message]
2018-03-15  4:33     ` Andrew Fish

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E1E6C13@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox