From: "Gao, Liming" <liming.gao@intel.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Feng, YunhuaX" <yunhuax.feng@intel.com>
Subject: Re: [Patch] BaseTools: Fix bug for VOID* DynamicDefault Pcd use Flexible format
Date: Sun, 18 Mar 2018 02:54:26 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1E866C@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1521272251-17504-1-git-send-email-yonghong.zhu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Yonghong Zhu
> Sent: Saturday, March 17, 2018 3:38 PM
> To: edk2-devel@lists.01.org
> Cc: Feng, YunhuaX <yunhuax.feng@intel.com>
> Subject: [edk2] [Patch] BaseTools: Fix bug for VOID* DynamicDefault Pcd use Flexible format
>
> From: Yunhua Feng <yunhuax.feng@intel.com>
>
> define a flexible pcd format in Dyanmic/DynamicExDefault section,
> it cause build error.
> [PcdsDynamicExDefault.common.DEFAULT]
> pcdToken.Name|{GUID("11111111-2222-42eb-b5eb-fef31d207cb4")}
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
> ---
> BaseTools/Source/Python/Common/Misc.py | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/BaseTools/Source/Python/Common/Misc.py b/BaseTools/Source/Python/Common/Misc.py
> index 2086b4c..7d44fdc 100644
> --- a/BaseTools/Source/Python/Common/Misc.py
> +++ b/BaseTools/Source/Python/Common/Misc.py
> @@ -1718,18 +1718,10 @@ def AnalyzeDscPcd(Setting, PcdType, DataType=''):
> Type = FieldList[1]
> else:
> Type = DataType
> if len(FieldList) > 2:
> Size = FieldList[2]
> - else:
> - if Type == 'VOID*':
> - if Value.startswith("L"):
> - Size = str((len(Value)- 3 + 1) * 2)
> - elif Value.startswith("{"):
> - Size = str(len(Value.split(",")))
> - else:
> - Size = str(len(Value) -2 + 1 )
> if DataType == "":
> IsValid = (len(FieldList) <= 1)
> else:
> IsValid = (len(FieldList) <= 3)
>
> --
> 2.6.1.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2018-03-18 2:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-17 7:37 [Patch] BaseTools: Fix bug for VOID* DynamicDefault Pcd use Flexible format Yonghong Zhu
2018-03-18 2:54 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E1E866C@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox