From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 16F0B223FCF34 for ; Sat, 17 Mar 2018 19:48:05 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Mar 2018 19:54:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,323,1517904000"; d="scan'208";a="28921933" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga002.fm.intel.com with ESMTP; 17 Mar 2018 19:54:31 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 17 Mar 2018 19:54:31 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 17 Mar 2018 19:54:31 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.226]) by shsmsx102.ccr.corp.intel.com ([169.254.2.80]) with mapi id 14.03.0319.002; Sun, 18 Mar 2018 10:54:27 +0800 From: "Gao, Liming" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" CC: "Feng, YunhuaX" Thread-Topic: [edk2] [Patch] BaseTools: Fix bug for VOID* DynamicDefault Pcd use Flexible format Thread-Index: AQHTvcLWF5NRr6JcnkiFdDm0dF2n3aPVTScw Date: Sun, 18 Mar 2018 02:54:26 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1E866C@SHSMSX104.ccr.corp.intel.com> References: <1521272251-17504-1-git-send-email-yonghong.zhu@intel.com> In-Reply-To: <1521272251-17504-1-git-send-email-yonghong.zhu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools: Fix bug for VOID* DynamicDefault Pcd use Flexible format X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Mar 2018 02:48:06 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Yo= nghong Zhu > Sent: Saturday, March 17, 2018 3:38 PM > To: edk2-devel@lists.01.org > Cc: Feng, YunhuaX > Subject: [edk2] [Patch] BaseTools: Fix bug for VOID* DynamicDefault Pcd u= se Flexible format >=20 > From: Yunhua Feng >=20 > define a flexible pcd format in Dyanmic/DynamicExDefault section, > it cause build error. > [PcdsDynamicExDefault.common.DEFAULT] > pcdToken.Name|{GUID("11111111-2222-42eb-b5eb-fef31d207cb4")} >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Yonghong Zhu > --- > BaseTools/Source/Python/Common/Misc.py | 8 -------- > 1 file changed, 8 deletions(-) >=20 > diff --git a/BaseTools/Source/Python/Common/Misc.py b/BaseTools/Source/Py= thon/Common/Misc.py > index 2086b4c..7d44fdc 100644 > --- a/BaseTools/Source/Python/Common/Misc.py > +++ b/BaseTools/Source/Python/Common/Misc.py > @@ -1718,18 +1718,10 @@ def AnalyzeDscPcd(Setting, PcdType, DataType=3D''= ): > Type =3D FieldList[1] > else: > Type =3D DataType > if len(FieldList) > 2: > Size =3D FieldList[2] > - else: > - if Type =3D=3D 'VOID*': > - if Value.startswith("L"): > - Size =3D str((len(Value)- 3 + 1) * 2) > - elif Value.startswith("{"): > - Size =3D str(len(Value.split(","))) > - else: > - Size =3D str(len(Value) -2 + 1 ) > if DataType =3D=3D "": > IsValid =3D (len(FieldList) <=3D 1) > else: > IsValid =3D (len(FieldList) <=3D 3) >=20 > -- > 2.6.1.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel