From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 09758225B02A4 for ; Tue, 20 Mar 2018 01:38:57 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Mar 2018 01:45:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,334,1517904000"; d="scan'208";a="213163160" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga005.fm.intel.com with ESMTP; 20 Mar 2018 01:45:26 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 20 Mar 2018 01:45:26 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 20 Mar 2018 01:45:23 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.226]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.129]) with mapi id 14.03.0319.002; Tue, 20 Mar 2018 16:45:22 +0800 From: "Gao, Liming" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch] BaseTools: Add Feature Flag Pcd Type into Override list Thread-Index: AQHTwCS8wv8laEkF60upzuWxa3Xg7qPYzz4w Date: Tue, 20 Mar 2018 08:45:20 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1EA474@SHSMSX104.ccr.corp.intel.com> References: <1521534183-8444-1-git-send-email-yonghong.zhu@intel.com> In-Reply-To: <1521534183-8444-1-git-send-email-yonghong.zhu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools: Add Feature Flag Pcd Type into Override list X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Mar 2018 08:38:58 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Yo= nghong Zhu > Sent: Tuesday, March 20, 2018 4:23 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch] BaseTools: Add Feature Flag Pcd Type into Overrid= e list >=20 > when only define the PCD in the DEC file, and use --pcd feature, > we also need cover this case for Feature Flag Type. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Yonghong Zhu > --- > BaseTools/Source/Python/Workspace/DscBuildData.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py b/BaseTool= s/Source/Python/Workspace/DscBuildData.py > index 6e30b50..d60d491 100644 > --- a/BaseTools/Source/Python/Workspace/DscBuildData.py > +++ b/BaseTools/Source/Python/Workspace/DscBuildData.py > @@ -1257,11 +1257,12 @@ class DscBuildData(PlatformBuildClassObject): > else: > PcdInDec =3D self.DecPcds.get((Name,Guid)) > if PcdInDec: > PcdInDec.PcdValueFromComm =3D NoFiledValues[(Guid,Na= me)][0] > if PcdInDec.Type in [self._PCD_TYPE_STRING_[MODEL_PC= D_FIXED_AT_BUILD], > - self._PCD_TYPE_STRING_[MODEL_PCD= _PATCHABLE_IN_MODULE]]: > + self._PCD_TYPE_STRING_[MODEL_PCD= _PATCHABLE_IN_MODULE], > + self._PCD_TYPE_STRING_[MODEL_PCD= _FEATURE_FLAG]]: > self.Pcds[Name, Guid] =3D copy.deepcopy(PcdInDec= ) > self.Pcds[Name, Guid].DefaultValue =3D NoFiledVa= lues[( Guid,Name)][0] > return AllPcds > def UpdateStructuredPcds(self, TypeList, AllPcds): >=20 > -- > 2.6.1.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel