From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 411FC225E9645 for ; Tue, 20 Mar 2018 20:35:33 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Mar 2018 20:42:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,338,1517904000"; d="scan'208";a="213438098" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 20 Mar 2018 20:42:03 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 20 Mar 2018 20:42:03 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.226]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.108]) with mapi id 14.03.0319.002; Wed, 21 Mar 2018 11:42:01 +0800 From: "Gao, Liming" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch] BaseTools: Override Max size by build Option Pcd for HII type Thread-Index: AQHTwMGtKt3QM6ahmkWZvqDejXTnWKPaC5rg Date: Wed, 21 Mar 2018 03:42:00 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1EAC6B@SHSMSX104.ccr.corp.intel.com> References: <1521601605-5800-1-git-send-email-yonghong.zhu@intel.com> In-Reply-To: <1521601605-5800-1-git-send-email-yonghong.zhu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools: Override Max size by build Option Pcd for HII type X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Mar 2018 03:35:33 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Yo= nghong Zhu > Sent: Wednesday, March 21, 2018 11:07 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch] BaseTools: Override Max size by build Option Pcd = for HII type >=20 > Current code will generate maxsize for HII type PCD when parser DSC > file, while this HII type PCD value maybe override in build command > per --pcd option, so the max size need re-calculate. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Yonghong Zhu > --- > BaseTools/Source/Python/Workspace/DscBuildData.py | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py b/BaseTool= s/Source/Python/Workspace/DscBuildData.py > index d60d491..8fe4d4f 100644 > --- a/BaseTools/Source/Python/Workspace/DscBuildData.py > +++ b/BaseTools/Source/Python/Workspace/DscBuildData.py > @@ -1252,10 +1252,18 @@ class DscBuildData(PlatformBuildClassObject): > SkuInfo.DefaultValue =3D NoFiledValues[(Pcd.= TokenSpaceGuidCName,Pcd.TokenCName)][0] > else: > SkuInfo.HiiDefaultValue =3D NoFiledValues[(P= cd.TokenSpaceGuidCName,Pcd.TokenCName)][0] > for defaultstore in SkuInfo.DefaultStoreDict= : > SkuInfo.DefaultStoreDict[defaultstore] = =3D > NoFiledValues[(Pcd.TokenSpaceGuidCName,Pcd.TokenCName)][0] > + if Pcd.Type in [self._PCD_TYPE_STRING_[MODEL_PCD_DYN= AMIC_EX_HII], > self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_HII]]: > + if Pcd.DatumType =3D=3D "VOID*": > + if not Pcd.MaxDatumSize: > + Pcd.MaxDatumSize =3D '0' > + CurrentSize =3D int(Pcd.MaxDatumSize,16) if = Pcd.MaxDatumSize.upper().startswith("0X") else > int(Pcd.MaxDatumSize) > + OptionSize =3D len((StringToArray(Pcd.PcdVal= ueFromComm)).split(",")) > + MaxSize =3D max(CurrentSize, OptionSize) > + Pcd.MaxDatumSize =3D str(MaxSize) > else: > PcdInDec =3D self.DecPcds.get((Name,Guid)) > if PcdInDec: > PcdInDec.PcdValueFromComm =3D NoFiledValues[(Guid,Na= me)][0] > if PcdInDec.Type in [self._PCD_TYPE_STRING_[MODEL_PC= D_FIXED_AT_BUILD], > -- > 2.6.1.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel