Re: [patch 2/2] BaseTool/VfrCompile: Fix potential memory leak issue

["Gao, Liming" <liming.gao@intel.com>]

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Bi, Dandan
> Sent: Tuesday, February 27, 2018 1:54 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [patch 2/2] BaseTool/VfrCompile: Fix potential memory leak issue
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=771
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp b/BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp
> index 9bdc544..5cab7bb 100644
> --- a/BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp
> +++ b/BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp
> @@ -3502,10 +3502,14 @@ CVfrStringDB::SetStringFileName(IN CHAR8 *StringFileName)
> 
>    if (StringFileName == NULL) {
>      return;
>    }
> 
> +  if (mStringFileName != NULL) {
> +    delete[] mStringFileName;
> +  }
> +
>    FileLen = strlen (StringFileName) + 1;
>    mStringFileName = new CHAR8[FileLen];
>    if (mStringFileName == NULL) {
>      return;
>    }
> --
> 1.9.5.msysgit.1