From: "Gao, Liming" <liming.gao@intel.com>
To: Pete Batard <pete@akeo.ie>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH 0/2] MdePkg/Library: Add missing .asm files for VS2017/ARM64
Date: Thu, 29 Mar 2018 02:46:31 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1EF5FB@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20180328155521.7312-1-pete@akeo.ie>
I have no comments to add ARM64 ASM files. Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: Pete Batard [mailto:pete@akeo.ie]
> Sent: Wednesday, March 28, 2018 11:55 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>; ard.biesheuvel@linaro.org
> Subject: [PATCH 0/2] MdePkg/Library: Add missing .asm files for VS2017/ARM64
>
> Someone using VS2017 to compile a driver for ARM64 reported that a port
> of BaseSynchronizationLib/AArch64/Synchronization.S was missing for their
> compilation to succeed. This patch adds it.
>
> For completion, we also add MSFT versions of CpuFlushTlb and CpuSleep in
> MdePkg/Library/BaseCpuLib as we suspect these might be needed too.
>
> Regards,
>
> /Pete
>
> Pete Batard (2):
> MdePkg/Library/BaseSynchronizationLib: Enable VS2017/ARM64 builds
> MdePkg/Library/BaseCpuLib: Enable VS2017/ARM64 builds
>
> MdePkg/Library/BaseCpuLib/AArch64/CpuFlushTlb.asm | 39 ++++
> MdePkg/Library/BaseCpuLib/AArch64/CpuSleep.asm | 40 ++++
> MdePkg/Library/BaseCpuLib/BaseCpuLib.inf | 8 +-
> MdePkg/Library/BaseSynchronizationLib/AArch64/Synchronization.asm | 205 ++++++++++++++++++++
> MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf | 3 +-
> 5 files changed, 291 insertions(+), 4 deletions(-)
> create mode 100644 MdePkg/Library/BaseCpuLib/AArch64/CpuFlushTlb.asm
> create mode 100644 MdePkg/Library/BaseCpuLib/AArch64/CpuSleep.asm
> create mode 100644 MdePkg/Library/BaseSynchronizationLib/AArch64/Synchronization.asm
>
> --
> 2.9.3.windows.2
prev parent reply other threads:[~2018-03-29 2:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 15:55 [PATCH 0/2] MdePkg/Library: Add missing .asm files for VS2017/ARM64 Pete Batard
2018-03-28 15:55 ` [PATCH 1/2] MdePkg/Library/BaseSynchronizationLib: Enable VS2017/ARM64 builds Pete Batard
2018-03-28 15:55 ` [PATCH 2/2] MdePkg/Library/BaseCpuLib: " Pete Batard
2018-03-29 2:46 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E1EF5FB@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox