From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4AFA6224DD123 for ; Wed, 28 Mar 2018 19:39:57 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Mar 2018 19:46:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,374,1517904000"; d="scan'208";a="41627449" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga004.fm.intel.com with ESMTP; 28 Mar 2018 19:46:36 -0700 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 28 Mar 2018 19:46:35 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 28 Mar 2018 19:46:35 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.226]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.129]) with mapi id 14.03.0319.002; Thu, 29 Mar 2018 10:46:32 +0800 From: "Gao, Liming" To: Pete Batard , "edk2-devel@lists.01.org" CC: "ard.biesheuvel@linaro.org" Thread-Topic: [PATCH 0/2] MdePkg/Library: Add missing .asm files for VS2017/ARM64 Thread-Index: AQHTxq05wD6t+Bt7EEWK0CBdmK424KPmgtlg Date: Thu, 29 Mar 2018 02:46:31 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1EF5FB@SHSMSX104.ccr.corp.intel.com> References: <20180328155521.7312-1-pete@akeo.ie> In-Reply-To: <20180328155521.7312-1-pete@akeo.ie> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 0/2] MdePkg/Library: Add missing .asm files for VS2017/ARM64 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2018 02:39:57 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I have no comments to add ARM64 ASM files. Reviewed-by: Liming Gao > -----Original Message----- > From: Pete Batard [mailto:pete@akeo.ie] > Sent: Wednesday, March 28, 2018 11:55 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; ard.biesheuvel@linaro.org > Subject: [PATCH 0/2] MdePkg/Library: Add missing .asm files for VS2017/AR= M64 >=20 > Someone using VS2017 to compile a driver for ARM64 reported that a port > of BaseSynchronizationLib/AArch64/Synchronization.S was missing for their > compilation to succeed. This patch adds it. >=20 > For completion, we also add MSFT versions of CpuFlushTlb and CpuSleep in > MdePkg/Library/BaseCpuLib as we suspect these might be needed too. >=20 > Regards, >=20 > /Pete >=20 > Pete Batard (2): > MdePkg/Library/BaseSynchronizationLib: Enable VS2017/ARM64 builds > MdePkg/Library/BaseCpuLib: Enable VS2017/ARM64 builds >=20 > MdePkg/Library/BaseCpuLib/AArch64/CpuFlushTlb.asm | 39 = ++++ > MdePkg/Library/BaseCpuLib/AArch64/CpuSleep.asm | 40 = ++++ > MdePkg/Library/BaseCpuLib/BaseCpuLib.inf | 8 = +- > MdePkg/Library/BaseSynchronizationLib/AArch64/Synchronization.asm | 205 = ++++++++++++++++++++ > MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf | 3 = +- > 5 files changed, 291 insertions(+), 4 deletions(-) > create mode 100644 MdePkg/Library/BaseCpuLib/AArch64/CpuFlushTlb.asm > create mode 100644 MdePkg/Library/BaseCpuLib/AArch64/CpuSleep.asm > create mode 100644 MdePkg/Library/BaseSynchronizationLib/AArch64/Synchro= nization.asm >=20 > -- > 2.9.3.windows.2