From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A08D421F2E0FA for ; Sun, 8 Apr 2018 22:37:41 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Apr 2018 22:37:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,426,1517904000"; d="scan'208";a="40506060" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by FMSMGA003.fm.intel.com with ESMTP; 08 Apr 2018 22:37:40 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 8 Apr 2018 22:37:40 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 8 Apr 2018 22:37:40 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.239]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.43]) with mapi id 14.03.0319.002; Mon, 9 Apr 2018 13:37:38 +0800 From: "Gao, Liming" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch] BaseTools: Pcds in [Components] are not display correct in the report Thread-Index: AQHTyjGjhg9fnuXXCE6r3B2Y+hGjyqP39VWw Date: Mon, 9 Apr 2018 05:37:37 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E20A4A9@SHSMSX104.ccr.corp.intel.com> References: <1522639225-19356-1-git-send-email-yonghong.zhu@intel.com> In-Reply-To: <1522639225-19356-1-git-send-email-yonghong.zhu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools: Pcds in [Components] are not display correct in the report X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Apr 2018 05:37:41 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Monday, April 02, 2018 11:20 AM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch] BaseTools: Pcds in [Components] are not display >correct in the report > >The Pcd used in [Components] section, the PCD value is displayed >incorrect in the build report because the PCD default value was not >override. > >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Yonghong Zhu >--- > BaseTools/Source/Python/build/BuildReport.py | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/BaseTools/Source/Python/build/BuildReport.py >b/BaseTools/Source/Python/build/BuildReport.py >index 6a79e23..e06c352 100644 >--- a/BaseTools/Source/Python/build/BuildReport.py >+++ b/BaseTools/Source/Python/build/BuildReport.py >@@ -969,10 +969,11 @@ class PcdReport(object): > PcdValue =3D DscDefaultValue > if ModulePcdSet is not None: > if (Pcd.TokenCName, Pcd.TokenSpaceGuidCName, Type= ) not in >ModulePcdSet: > continue > InfDefault, PcdValue =3D ModulePcdSet[Pcd.TokenCN= ame, >Pcd.TokenSpaceGuidCName, Type] >+ Pcd.DefaultValue =3D PcdValue > if InfDefault =3D=3D "": > InfDefault =3D None > > BuildOptionMatch =3D False > if GlobalData.BuildOptionPcd: >-- >2.6.1.windows.1 > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel