From: "Gao, Liming" <liming.gao@intel.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTools: Pcd not used info should not in Module PCD section
Date: Mon, 9 Apr 2018 05:38:09 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E20A4B7@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1522639208-22876-1-git-send-email-yonghong.zhu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Yonghong Zhu
>Sent: Monday, April 02, 2018 11:20 AM
>To: edk2-devel@lists.01.org
>Subject: [edk2] [Patch] BaseTools: Pcd not used info should not in Module
>PCD section
>
>Pcds in Conditional Directives and Pcds not used are Platform Level
>info, it should not display in Module PCD Section.
>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
>---
> BaseTools/Source/Python/build/BuildReport.py | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
>diff --git a/BaseTools/Source/Python/build/BuildReport.py
>b/BaseTools/Source/Python/build/BuildReport.py
>index 966a2aa..6a79e23 100644
>--- a/BaseTools/Source/Python/build/BuildReport.py
>+++ b/BaseTools/Source/Python/build/BuildReport.py
>@@ -875,14 +875,15 @@ class PcdReport(object):
> DscDefaultValue = Pa.Platform.Pcds[(TokenCName,
>TokenSpaceGuidCName)].DscDefaultValue
> if DscDefaultValue:
> self.DscPcdDefault[(TokenCName, TokenSpaceGuidCName)] =
>DscDefaultValue
>
> def GenerateReport(self, File, ModulePcdSet):
>- if self.ConditionalPcds:
>- self.GenerateReportDetail(File, ModulePcdSet, 1)
>- if self.UnusedPcds:
>- self.GenerateReportDetail(File, ModulePcdSet, 2)
>+ if not ModulePcdSet:
>+ if self.ConditionalPcds:
>+ self.GenerateReportDetail(File, ModulePcdSet, 1)
>+ if self.UnusedPcds:
>+ self.GenerateReportDetail(File, ModulePcdSet, 2)
> self.GenerateReportDetail(File, ModulePcdSet)
>
> ##
> # Generate report for PCD information
> #
>@@ -902,11 +903,11 @@ class PcdReport(object):
> if ReportSubType == 1:
> PcdDict = self.ConditionalPcds
> elif ReportSubType == 2:
> PcdDict = self.UnusedPcds
>
>- if ModulePcdSet is None:
>+ if not ModulePcdSet:
> FileWrite(File, gSectionStart)
> if ReportSubType == 1:
> FileWrite(File, "Conditional Directives used by the build system")
> elif ReportSubType == 2:
> FileWrite(File, "PCDs not used by modules or in conditional directives")
>--
>2.6.1.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2018-04-09 5:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-02 3:20 [Patch] BaseTools: Pcd not used info should not in Module PCD section Yonghong Zhu
2018-04-09 5:38 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E20A4B7@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox