From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4071121F2E0FA for ; Sun, 8 Apr 2018 22:38:12 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Apr 2018 22:38:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,426,1517904000"; d="scan'208";a="40506201" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by FMSMGA003.fm.intel.com with ESMTP; 08 Apr 2018 22:38:11 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 8 Apr 2018 22:38:11 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 8 Apr 2018 22:38:11 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.239]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.43]) with mapi id 14.03.0319.002; Mon, 9 Apr 2018 13:38:09 +0800 From: "Gao, Liming" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch] BaseTools: Pcd not used info should not in Module PCD section Thread-Index: AQHTyjGZsVXQclK3P0+o8E0amv9FqqP39XwA Date: Mon, 9 Apr 2018 05:38:09 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E20A4B7@SHSMSX104.ccr.corp.intel.com> References: <1522639208-22876-1-git-send-email-yonghong.zhu@intel.com> In-Reply-To: <1522639208-22876-1-git-send-email-yonghong.zhu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools: Pcd not used info should not in Module PCD section X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Apr 2018 05:38:12 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Monday, April 02, 2018 11:20 AM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch] BaseTools: Pcd not used info should not in Module >PCD section > >Pcds in Conditional Directives and Pcds not used are Platform Level >info, it should not display in Module PCD Section. > >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Yonghong Zhu >--- > BaseTools/Source/Python/build/BuildReport.py | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > >diff --git a/BaseTools/Source/Python/build/BuildReport.py >b/BaseTools/Source/Python/build/BuildReport.py >index 966a2aa..6a79e23 100644 >--- a/BaseTools/Source/Python/build/BuildReport.py >+++ b/BaseTools/Source/Python/build/BuildReport.py >@@ -875,14 +875,15 @@ class PcdReport(object): > DscDefaultValue =3D Pa.Platform.Pcds[(TokenCName, >TokenSpaceGuidCName)].DscDefaultValue > if DscDefaultValue: > self.DscPcdDefault[(TokenCName, TokenSpaceGuidCName)]= =3D >DscDefaultValue > > def GenerateReport(self, File, ModulePcdSet): >- if self.ConditionalPcds: >- self.GenerateReportDetail(File, ModulePcdSet, 1) >- if self.UnusedPcds: >- self.GenerateReportDetail(File, ModulePcdSet, 2) >+ if not ModulePcdSet: >+ if self.ConditionalPcds: >+ self.GenerateReportDetail(File, ModulePcdSet, 1) >+ if self.UnusedPcds: >+ self.GenerateReportDetail(File, ModulePcdSet, 2) > self.GenerateReportDetail(File, ModulePcdSet) > > ## > # Generate report for PCD information > # >@@ -902,11 +903,11 @@ class PcdReport(object): > if ReportSubType =3D=3D 1: > PcdDict =3D self.ConditionalPcds > elif ReportSubType =3D=3D 2: > PcdDict =3D self.UnusedPcds > >- if ModulePcdSet is None: >+ if not ModulePcdSet: > FileWrite(File, gSectionStart) > if ReportSubType =3D=3D 1: > FileWrite(File, "Conditional Directives used by the build= system") > elif ReportSubType =3D=3D 2: > FileWrite(File, "PCDs not used by modules or in condition= al directives") >-- >2.6.1.windows.1 > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel