From: "Gao, Liming" <liming.gao@intel.com>
To: Laszlo Ersek <lersek@redhat.com>,
"Zhu, Yonghong" <yonghong.zhu@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTools: Fix the build error caused by eca980
Date: Wed, 11 Apr 2018 01:50:54 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E20C2F2@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <d92d7787-f93d-292d-b19a-31d5c08b3bdf@redhat.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Laszlo Ersek
> Sent: Wednesday, April 11, 2018 2:03 AM
> To: Zhu, Yonghong <yonghong.zhu@intel.com>; edk2-devel@lists.01.org
> Subject: Re: [edk2] [Patch] BaseTools: Fix the build error caused by eca980
>
> Hi Yonghong,
>
> On 04/10/18 15:28, Yonghong Zhu wrote:
> > Roll back the fixed at build pcd collection to include the pcd in
> > Module and Library.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
> > ---
> > BaseTools/Source/Python/AutoGen/AutoGen.py | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py b/BaseTools/Source/Python/AutoGen/AutoGen.py
> > index 9280ae4..dbc9f89 100644
> > --- a/BaseTools/Source/Python/AutoGen/AutoGen.py
> > +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py
> > @@ -1277,11 +1277,11 @@ class PlatformAutoGen(AutoGen):
> > def CollectFixedAtBuildPcds(self):
> > for LibAuto in self.LibraryAutoGenList:
> > FixedAtBuildPcds = {}
> > ShareFixedAtBuildPcdsSameValue = {}
> > for Module in LibAuto._ReferenceModules:
> > - for Pcd in Module.FixedAtBuildPcds:
> > + for Pcd in Module.FixedAtBuildPcds + LibAuto.FixedAtBuildPcds:
> > key = ".".join((Pcd.TokenSpaceGuidCName,Pcd.TokenCName))
> > if key not in FixedAtBuildPcds:
> > ShareFixedAtBuildPcdsSameValue[key] = True
> > FixedAtBuildPcds[key] = Pcd.DefaultValue
> > else:
> >
>
> this change fixes the ArmVirtQemu build error for me.
>
> I suggest using commit hash abbreviations longer than just 6 nibbles. 12
> nibbles are more future proof (that size is used by the Linux kernel)
> and it's also not a large burden to use. So, I suggest replacing
> "eca980" in the subject line with "eca980c0c899".
>
> With that change:
>
> Tested-by: Laszlo Ersek <lersek@redhat.com>
>
> Thanks!
> Laszlo
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2018-04-11 1:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 13:28 [Patch] BaseTools: Fix the build error caused by eca980 Yonghong Zhu
2018-04-10 18:02 ` Laszlo Ersek
2018-04-11 1:50 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E20C2F2@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox