* [Patch] BaseTools: Correct the variable name
@ 2018-05-07 6:04 Yonghong Zhu
2018-05-07 7:17 ` Gao, Liming
0 siblings, 1 reply; 2+ messages in thread
From: Yonghong Zhu @ 2018-05-07 6:04 UTC (permalink / raw)
To: edk2-devel
the commit bff74750 introduce a undefined variable name 'scope' cause build
failure, it should use 'Scope'.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
---
BaseTools/Source/Python/GenFds/FdfParser.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Source/Python/GenFds/FdfParser.py b/BaseTools/Source/Python/GenFds/FdfParser.py
index 223b453..8a9296c 100644
--- a/BaseTools/Source/Python/GenFds/FdfParser.py
+++ b/BaseTools/Source/Python/GenFds/FdfParser.py
@@ -1133,11 +1133,11 @@ class FdfParser:
return False
@staticmethod
def __Verify(Name, Value, Scope):
# value verification only applies to numeric values.
- if scope not in TAB_PCD_NUMERIC_TYPES:
+ if Scope not in TAB_PCD_NUMERIC_TYPES:
return
ValueNumber = 0
try:
ValueNumber = int(Value, 0)
--
2.6.1.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Patch] BaseTools: Correct the variable name
2018-05-07 6:04 [Patch] BaseTools: Correct the variable name Yonghong Zhu
@ 2018-05-07 7:17 ` Gao, Liming
0 siblings, 0 replies; 2+ messages in thread
From: Gao, Liming @ 2018-05-07 7:17 UTC (permalink / raw)
To: Zhu, Yonghong, edk2-devel@lists.01.org
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Yonghong Zhu
>Sent: Monday, May 07, 2018 2:04 PM
>To: edk2-devel@lists.01.org
>Subject: [edk2] [Patch] BaseTools: Correct the variable name
>
>the commit bff74750 introduce a undefined variable name 'scope' cause build
>failure, it should use 'Scope'.
>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
>---
> BaseTools/Source/Python/GenFds/FdfParser.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/BaseTools/Source/Python/GenFds/FdfParser.py
>b/BaseTools/Source/Python/GenFds/FdfParser.py
>index 223b453..8a9296c 100644
>--- a/BaseTools/Source/Python/GenFds/FdfParser.py
>+++ b/BaseTools/Source/Python/GenFds/FdfParser.py
>@@ -1133,11 +1133,11 @@ class FdfParser:
> return False
>
> @staticmethod
> def __Verify(Name, Value, Scope):
> # value verification only applies to numeric values.
>- if scope not in TAB_PCD_NUMERIC_TYPES:
>+ if Scope not in TAB_PCD_NUMERIC_TYPES:
> return
>
> ValueNumber = 0
> try:
> ValueNumber = int(Value, 0)
>--
>2.6.1.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-07 7:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-07 6:04 [Patch] BaseTools: Correct the variable name Yonghong Zhu
2018-05-07 7:17 ` Gao, Liming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox