* [PATCH v2 1/2] MdePkg/UefiLib: Add 'OUT' decorator where necessary.
@ 2018-05-05 14:23 Marvin Häuser
2018-05-07 12:13 ` Gao, Liming
0 siblings, 1 reply; 2+ messages in thread
From: Marvin Häuser @ 2018-05-05 14:23 UTC (permalink / raw)
To: edk2-devel@lists.01.org; +Cc: michael.d.kinney@intel.com, liming.gao@intel.com
The functions AddUnicodeString() and AddUnicodeString2() might return
a new value into their parameter UnicodeStringTable, hence add the
appropiate 'OUT' decorator.
V2: Update FrameworkUefiLib as well.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marvin Haeuser <Marvin.Haeuser@outlook.com>
---
MdePkg/Library/UefiLib/UefiLib.c | 18 +++++++++---------
MdePkg/Include/Library/UefiLib.h | 18 +++++++++---------
2 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/MdePkg/Library/UefiLib/UefiLib.c b/MdePkg/Library/UefiLib/UefiLib.c
index f1a3f1c7af05..ba449a1c34ce 100644
--- a/MdePkg/Library/UefiLib/UefiLib.c
+++ b/MdePkg/Library/UefiLib/UefiLib.c
@@ -888,10 +888,10 @@ LookupUnicodeString2 (
EFI_STATUS
EFIAPI
AddUnicodeString (
- IN CONST CHAR8 *Language,
- IN CONST CHAR8 *SupportedLanguages,
- IN EFI_UNICODE_STRING_TABLE **UnicodeStringTable,
- IN CONST CHAR16 *UnicodeString
+ IN CONST CHAR8 *Language,
+ IN CONST CHAR8 *SupportedLanguages,
+ IN OUT EFI_UNICODE_STRING_TABLE **UnicodeStringTable,
+ IN CONST CHAR16 *UnicodeString
)
{
UINTN NumberOfEntries;
@@ -1065,11 +1065,11 @@ AddUnicodeString (
EFI_STATUS
EFIAPI
AddUnicodeString2 (
- IN CONST CHAR8 *Language,
- IN CONST CHAR8 *SupportedLanguages,
- IN EFI_UNICODE_STRING_TABLE **UnicodeStringTable,
- IN CONST CHAR16 *UnicodeString,
- IN BOOLEAN Iso639Language
+ IN CONST CHAR8 *Language,
+ IN CONST CHAR8 *SupportedLanguages,
+ IN OUT EFI_UNICODE_STRING_TABLE **UnicodeStringTable,
+ IN CONST CHAR16 *UnicodeString,
+ IN BOOLEAN Iso639Language
)
{
UINTN NumberOfEntries;
diff --git a/MdePkg/Include/Library/UefiLib.h b/MdePkg/Include/Library/UefiLib.h
index 54bc2cc5a334..256498e3fd8d 100644
--- a/MdePkg/Include/Library/UefiLib.h
+++ b/MdePkg/Include/Library/UefiLib.h
@@ -587,10 +587,10 @@ LookupUnicodeString2 (
EFI_STATUS
EFIAPI
AddUnicodeString (
- IN CONST CHAR8 *Language,
- IN CONST CHAR8 *SupportedLanguages,
- IN EFI_UNICODE_STRING_TABLE **UnicodeStringTable,
- IN CONST CHAR16 *UnicodeString
+ IN CONST CHAR8 *Language,
+ IN CONST CHAR8 *SupportedLanguages,
+ IN OUT EFI_UNICODE_STRING_TABLE **UnicodeStringTable,
+ IN CONST CHAR16 *UnicodeString
);
/**
@@ -638,11 +638,11 @@ AddUnicodeString (
EFI_STATUS
EFIAPI
AddUnicodeString2 (
- IN CONST CHAR8 *Language,
- IN CONST CHAR8 *SupportedLanguages,
- IN EFI_UNICODE_STRING_TABLE **UnicodeStringTable,
- IN CONST CHAR16 *UnicodeString,
- IN BOOLEAN Iso639Language
+ IN CONST CHAR8 *Language,
+ IN CONST CHAR8 *SupportedLanguages,
+ IN OUT EFI_UNICODE_STRING_TABLE **UnicodeStringTable,
+ IN CONST CHAR16 *UnicodeString,
+ IN BOOLEAN Iso639Language
);
/**
--
2.17.0.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2 1/2] MdePkg/UefiLib: Add 'OUT' decorator where necessary.
2018-05-05 14:23 [PATCH v2 1/2] MdePkg/UefiLib: Add 'OUT' decorator where necessary Marvin Häuser
@ 2018-05-07 12:13 ` Gao, Liming
0 siblings, 0 replies; 2+ messages in thread
From: Gao, Liming @ 2018-05-07 12:13 UTC (permalink / raw)
To: Marvin.Haeuser@outlook.com, edk2-devel@lists.01.org; +Cc: Kinney, Michael D
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Marvin H?user
> Sent: Saturday, May 5, 2018 10:24 PM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [edk2] [PATCH v2 1/2] MdePkg/UefiLib: Add 'OUT' decorator where necessary.
>
> The functions AddUnicodeString() and AddUnicodeString2() might return
> a new value into their parameter UnicodeStringTable, hence add the
> appropiate 'OUT' decorator.
>
> V2: Update FrameworkUefiLib as well.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marvin Haeuser <Marvin.Haeuser@outlook.com>
> ---
> MdePkg/Library/UefiLib/UefiLib.c | 18 +++++++++---------
> MdePkg/Include/Library/UefiLib.h | 18 +++++++++---------
> 2 files changed, 18 insertions(+), 18 deletions(-)
>
> diff --git a/MdePkg/Library/UefiLib/UefiLib.c b/MdePkg/Library/UefiLib/UefiLib.c
> index f1a3f1c7af05..ba449a1c34ce 100644
> --- a/MdePkg/Library/UefiLib/UefiLib.c
> +++ b/MdePkg/Library/UefiLib/UefiLib.c
> @@ -888,10 +888,10 @@ LookupUnicodeString2 (
> EFI_STATUS
> EFIAPI
> AddUnicodeString (
> - IN CONST CHAR8 *Language,
> - IN CONST CHAR8 *SupportedLanguages,
> - IN EFI_UNICODE_STRING_TABLE **UnicodeStringTable,
> - IN CONST CHAR16 *UnicodeString
> + IN CONST CHAR8 *Language,
> + IN CONST CHAR8 *SupportedLanguages,
> + IN OUT EFI_UNICODE_STRING_TABLE **UnicodeStringTable,
> + IN CONST CHAR16 *UnicodeString
> )
> {
> UINTN NumberOfEntries;
> @@ -1065,11 +1065,11 @@ AddUnicodeString (
> EFI_STATUS
> EFIAPI
> AddUnicodeString2 (
> - IN CONST CHAR8 *Language,
> - IN CONST CHAR8 *SupportedLanguages,
> - IN EFI_UNICODE_STRING_TABLE **UnicodeStringTable,
> - IN CONST CHAR16 *UnicodeString,
> - IN BOOLEAN Iso639Language
> + IN CONST CHAR8 *Language,
> + IN CONST CHAR8 *SupportedLanguages,
> + IN OUT EFI_UNICODE_STRING_TABLE **UnicodeStringTable,
> + IN CONST CHAR16 *UnicodeString,
> + IN BOOLEAN Iso639Language
> )
> {
> UINTN NumberOfEntries;
> diff --git a/MdePkg/Include/Library/UefiLib.h b/MdePkg/Include/Library/UefiLib.h
> index 54bc2cc5a334..256498e3fd8d 100644
> --- a/MdePkg/Include/Library/UefiLib.h
> +++ b/MdePkg/Include/Library/UefiLib.h
> @@ -587,10 +587,10 @@ LookupUnicodeString2 (
> EFI_STATUS
> EFIAPI
> AddUnicodeString (
> - IN CONST CHAR8 *Language,
> - IN CONST CHAR8 *SupportedLanguages,
> - IN EFI_UNICODE_STRING_TABLE **UnicodeStringTable,
> - IN CONST CHAR16 *UnicodeString
> + IN CONST CHAR8 *Language,
> + IN CONST CHAR8 *SupportedLanguages,
> + IN OUT EFI_UNICODE_STRING_TABLE **UnicodeStringTable,
> + IN CONST CHAR16 *UnicodeString
> );
>
> /**
> @@ -638,11 +638,11 @@ AddUnicodeString (
> EFI_STATUS
> EFIAPI
> AddUnicodeString2 (
> - IN CONST CHAR8 *Language,
> - IN CONST CHAR8 *SupportedLanguages,
> - IN EFI_UNICODE_STRING_TABLE **UnicodeStringTable,
> - IN CONST CHAR16 *UnicodeString,
> - IN BOOLEAN Iso639Language
> + IN CONST CHAR8 *Language,
> + IN CONST CHAR8 *SupportedLanguages,
> + IN OUT EFI_UNICODE_STRING_TABLE **UnicodeStringTable,
> + IN CONST CHAR16 *UnicodeString,
> + IN BOOLEAN Iso639Language
> );
>
> /**
> --
> 2.17.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-07 12:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-05 14:23 [PATCH v2 1/2] MdePkg/UefiLib: Add 'OUT' decorator where necessary Marvin Häuser
2018-05-07 12:13 ` Gao, Liming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox