[PATCH v2 2/2] IntelFrameworkPkg/FrameworkUefiLib: Add 'OUT' decorator where necessary.

[PATCH v2 2/2] IntelFrameworkPkg/FrameworkUefiLib: Add 'OUT' decorator where necessary.

[Marvin Häuser]

The functions AddUnicodeString() and AddUnicodeString2() might return
a new value into their parameter UnicodeStringTable, hence add the
appropiate 'OUT' decorator.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marvin Haeuser <Marvin.Haeuser@outlook.com>
---
 IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c | 19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c b/IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c
index 895ff39fc140..61a32e297606 100644
--- a/IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c
+++ b/IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c
@@ -865,11 +865,10 @@ LookupUnicodeString2 (
 **/
 EFI_STATUS
 EFIAPI
-AddUnicodeString (
-  IN CONST CHAR8               *Language,
-  IN CONST CHAR8               *SupportedLanguages,
-  IN EFI_UNICODE_STRING_TABLE  **UnicodeStringTable,
-  IN CONST CHAR16              *UnicodeString
+  IN     CONST CHAR8               *Language,
+  IN     CONST CHAR8               *SupportedLanguages,
+  IN OUT EFI_UNICODE_STRING_TABLE  **UnicodeStringTable,
+  IN     CONST CHAR16              *UnicodeString
   )
 {
   UINTN                     NumberOfEntries;
@@ -1043,11 +1042,11 @@ AddUnicodeString (
 EFI_STATUS
 EFIAPI
 AddUnicodeString2 (
-  IN CONST CHAR8               *Language,
-  IN CONST CHAR8               *SupportedLanguages,
-  IN EFI_UNICODE_STRING_TABLE  **UnicodeStringTable,
-  IN CONST CHAR16              *UnicodeString,
-  IN BOOLEAN                   Iso639Language
+  IN     CONST CHAR8               *Language,
+  IN     CONST CHAR8               *SupportedLanguages,
+  IN OUT EFI_UNICODE_STRING_TABLE  **UnicodeStringTable,
+  IN     CONST CHAR16              *UnicodeString,
+  IN     BOOLEAN                   Iso639Language
   )
 {
   UINTN                     NumberOfEntries;
-- 
2.17.0.windows.1

Re: [PATCH v2 2/2] IntelFrameworkPkg/FrameworkUefiLib: Add 'OUT' decorator where necessary.

[Gao, Liming]

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Marvin H?user
> Sent: Saturday, May 5, 2018 10:24 PM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [edk2] [PATCH v2 2/2] IntelFrameworkPkg/FrameworkUefiLib: Add 'OUT' decorator where necessary.
> 
> The functions AddUnicodeString() and AddUnicodeString2() might return
> a new value into their parameter UnicodeStringTable, hence add the
> appropiate 'OUT' decorator.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marvin Haeuser <Marvin.Haeuser@outlook.com>
> ---
>  IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c | 19 +++++++++----------
>  1 file changed, 9 insertions(+), 10 deletions(-)
> 
> diff --git a/IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c b/IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c
> index 895ff39fc140..61a32e297606 100644
> --- a/IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c
> +++ b/IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c
> @@ -865,11 +865,10 @@ LookupUnicodeString2 (
>  **/
>  EFI_STATUS
>  EFIAPI
> -AddUnicodeString (
> -  IN CONST CHAR8               *Language,
> -  IN CONST CHAR8               *SupportedLanguages,
> -  IN EFI_UNICODE_STRING_TABLE  **UnicodeStringTable,
> -  IN CONST CHAR16              *UnicodeString
> +  IN     CONST CHAR8               *Language,
> +  IN     CONST CHAR8               *SupportedLanguages,
> +  IN OUT EFI_UNICODE_STRING_TABLE  **UnicodeStringTable,
> +  IN     CONST CHAR16              *UnicodeString
>    )
>  {
>    UINTN                     NumberOfEntries;
> @@ -1043,11 +1042,11 @@ AddUnicodeString (
>  EFI_STATUS
>  EFIAPI
>  AddUnicodeString2 (
> -  IN CONST CHAR8               *Language,
> -  IN CONST CHAR8               *SupportedLanguages,
> -  IN EFI_UNICODE_STRING_TABLE  **UnicodeStringTable,
> -  IN CONST CHAR16              *UnicodeString,
> -  IN BOOLEAN                   Iso639Language
> +  IN     CONST CHAR8               *Language,
> +  IN     CONST CHAR8               *SupportedLanguages,
> +  IN OUT EFI_UNICODE_STRING_TABLE  **UnicodeStringTable,
> +  IN     CONST CHAR16              *UnicodeString,
> +  IN     BOOLEAN                   Iso639Language
>    )
>  {
>    UINTN                     NumberOfEntries;
> --
> 2.17.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel